Uh oh!
There was an error while loading. Please reload this page.
Add support for BinaryFileResponse - #59
Open
Deltachaos wants to merge 3 commits into
Open
Conversation
mmoreram
commented
Aug 28, 2020
Member
Same here. This feature is really amazing. Thanks. |
Deltachaos
commented
Nov 26, 2020
Author
@mmoreram if you could rebase and add some tests this would be amazing :) |
mmoreram
commented
Jan 26, 2021
Member
@Deltachaos Still interested in this. Do you want to refactor this? Thanks! |
Deltachaos
commented
Feb 19, 2021
Author
@mmoreram i have currently no time to make the changes. So feel free to continue on my work. I would be happy if this feature makes it way to get merged as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is derived from #30
At the first stage add support for BinaryFileResponse using non blocking React filesystem