Uh oh!
There was an error while loading. Please reload this page.
Conversation
ddHandle vendor U-Boot interrupt lines that include timestamps, such as => [ 2.209] <INTERRUPT> and [ 115.141] <INTERRUPT>.
There was a problem hiding this comment.
审查摘要
此 PR 为 uboot-shell 增加带时间戳的 <INTERRUPT> 行识别,并补充聚焦的字节流测试;同时将易受 rustc 诊断渲染变化影响的公开 API trybuild 快照改为独立 Cargo 探针,更新中英文 README、crate 版本和锁文件。
影响范围
- 运行时行为仅影响 U-Boot 初始化时从
<INTERRUPT>行推导 prompt 的协议路径;现有普通 prompt 分支仍有回归测试,未发现对其他 shell、YMODEM 或配置契约的影响。 ostool的改动仅调整公开 API 边界测试方式,不改变导出接口或运行时行为。
验证
- 头提交
b3518fc00e46f0eb4304127df3be6212a3fe98b4的 2 个 GitHub Actions check 均成功;发现的target/tests/targetENOENT 注解来自非阻塞的 runner/cache 清理,未显示为本 PR 引起的检查失败。 - 本地
git diff --check origin/main...HEAD通过。 - 当前审查环境未安装 Cargo/Rust,因此未在本地重跑
cargo fmt --check、Clippy 和 crate 测试;对应 CI 已在精确头提交通过。 - 未发现同主题的重叠 PR。
此前没有 review、行内评论或 PR 对话需要复核。当前无未解决问题;剩余风险仅是未在真实 U-Boot 硬件上验证,现有覆盖为模拟字节流测试。
Powered by gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.