Skip to content

Configurable defaults#116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pupeno wants to merge 2 commits into
base:master
Choose a base branch
from
Open

Configurable defaults #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ed6ea
Allow defining a default host and port.
pupeno Sep 20, 2015
4568a7a
Merge remote-tracking branch 'refs/remotes/upstream/master' into conf…
pupeno Dec 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/XMLHttpRequest.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,11 @@ var Url = require("url");
var spawn = require("child_process").spawn;
var fs = require("fs");

exports.defaults = {
host: null,
port: null
}

exports.XMLHttpRequest = function() {
"use strict";

Expand DownExpand Up@@ -292,7 +297,7 @@ exports.XMLHttpRequest = function() {
case undefined:
case null:
case "":
host = "localhost";
host = exports.defaults.host || "localhost";
break;

default:
Expand DownExpand Up@@ -330,7 +335,7 @@ exports.XMLHttpRequest = function() {

// Default to port 80. If accessing localhost on another port be sure
// to use http://localhost:port/path
var port = url.port || (ssl ? 443 : 80);
var port = url.port || exports.defaults.port || (ssl ? 443 : 80);
// Add query string if one is used
var uri = url.pathname + (url.search ? url.search : "");

Expand Down