Skip to content

Expose xhr.withCredentials with correct default - #96

Merged
driverdan merged 1 commit into
driverdan:masterfrom
kumavis:patch-1
Oct 11, 2015
Merged

Expose xhr.withCredentials with correct default#96
driverdan merged 1 commit into
driverdan:masterfrom
kumavis:patch-1

Conversation

@kumavis

Copy link
Copy Markdown
Contributor

Fixes#71
Replaces #84

@novabyte

Copy link
Copy Markdown

+1 can we merge this in please.

@kumavis

Copy link
Copy Markdown
ContributorAuthor

re-reviewed my code change, and all seems good. this is the correct default behavior for XHRs in the browser. ready to merge.

@novabyte

Copy link
Copy Markdown

@kumavis Thanks for re-checking it. I just stumbled across this problem in jsdom with a AJAX library I'm using in some headless test cases. The AJAX library detects support for CORS requests with:

var cors = 'withCredentials' in tmpxhr;

This fails at the moment in jsdom (3.*) because the withCredentials property is not on the XMLHttpRequest object...

@novabyte

Copy link
Copy Markdown

@driverdan Please can you merge this into master and build a new release.

@kumavis

Copy link
Copy Markdown
ContributorAuthor

📲 come on dan drive it home 🚙

@mareksuscak

Copy link
Copy Markdown

Can we merge this thing @driverdan?

@mareksuscak

Copy link
Copy Markdown

@novabyte for working XHR in jsdom you can use my patch https://github.com/mareksuscak/jsdom-xhr-patch until this gets resolved and merged.

driverdan added a commit that referenced this pull request Oct 11, 2015
Expose xhr.withCredentials with correct default
@driverdan
driverdan merged commit 078626a into driverdan:masterOct 11, 2015
@kumavis

Copy link
Copy Markdown
ContributorAuthor

HE LIVES 👻

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to define withCredentials

4 participants

@kumavis@novabyte@mareksuscak@driverdan