Skip to content

Trap missing response/headers in getAllResponseHeaders (fix for #27)#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjbenson wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Trap missing response/headers in getAllResponseHeaders (fix for #27) #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/XMLHttpRequest.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ exports.XMLHttpRequest = function() {
// Set some default headers
var defaultHeaders = {
"User-Agent": "node-XMLHttpRequest",
"Accept": "*/*",
"Accept": "*/*"
};

var headers = defaultHeaders;
Expand DownExpand Up@@ -224,7 +224,7 @@ exports.XMLHttpRequest = function() {
* @return string A string with all response headers separated by CR+LF
*/
this.getAllResponseHeaders = function() {
if (this.readyState < this.HEADERS_RECEIVED || errorFlag) {
if (this.readyState < this.HEADERS_RECEIVED || errorFlag || !response || !response.headers) {
return "";
}
var result = "";
Expand All@@ -235,7 +235,7 @@ exports.XMLHttpRequest = function() {
result += i + ": " + response.headers[i] + "\r\n";
}
}
return result.substr(0, result.length - 2);
return result.substr(0, result.length > 1? result.length - 2: 0);
};

/**
Expand Down