Skip to content

Fix for py3.13+ by replacing past.basestring#1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-burns wants to merge 1 commit into
base:master
Choose a base branch
from
+2 −3
Open

Fix for py3.13+ by replacing past.basestring #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dronekit/__init__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@
import time

import monotonic
from past.builtins import basestring

from pymavlink import mavutil, mavwp
from pymavlink.dialects.v10 import ardupilotmega
Expand DownExpand Up@@ -1646,7 +1645,7 @@ def mode(self):

@mode.setter
def mode(self, v):
if isinstance(v, basestring):
if isinstance(v, (bytes, str)):

@peterbarkerpeterbarkerJan 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this technically be

Suggested change
ifisinstance(v, (bytes, str)):
ifisinstance(v, (unicode, str)):

?

Seriously, just:

Suggested change
ifisinstance(v, (bytes, str)):
ifisinstance(v, str):

... we don't need Python2 compatibility any more (pymavlink is no longer Python2-compliant so no new installs are going to work on Py2 anyway).

@r-burnsr-burnsJan 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think unicode exists in python3, at least by default. My understanding is that it's a python2 forward-compat alias for a python3 str.

I also think code that has historically supported python2 may still be passing bytes around as strings, so that's why the past module uses (bytes, str) instead of just str. If that's not the case here for dronekit, then I agree it's simpler to just use str.

v = VehicleMode(v)

if self._autopilot_type == mavutil.mavlink.MAV_AUTOPILOT_PX4:
Expand DownExpand Up@@ -2401,7 +2400,7 @@ def wait_ready(self, *types, **kwargs):
if list(types) == [True] or list(types) == []:
types = self._default_ready_attrs

if not all(isinstance(item, basestring) for item in types):
if not all(isinstance(item, (bytes, str)) for item in types):
raise ValueError('wait_ready expects one or more string arguments.')

# Wait for these attributes to have been set.
Expand Down