Skip to content

Support presto Decimal, Date and Timestamp types - #171

Open
devinstevenson wants to merge 2 commits into
dropbox:masterfrom
devinstevenson:support-presto-decimal-type
Open

Support presto Decimal, Date and Timestamp types#171
devinstevenson wants to merge 2 commits into
dropbox:masterfrom
devinstevenson:support-presto-decimal-type

Conversation

@devinstevenson

@devinstevensondevinstevenson commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

Hi @jingw.

I added support on Presto for decimal, date, and timestamp presto types. I also modified the tests to include a date type. The Travis CI test failed on python 3.6 seems to be a Travis CI issue. The tests passed on all other versions of python.

@codecov-io

codecov-io commented Oct 27, 2017

Copy link
Copy Markdown

Codecov Report

Merging #171 into master will decrease coverage by 0.24%.
The diff coverage is 97.56%.

Impacted file tree graph

@@ Coverage Diff @@## master #171 +/- ##
==========================================
- Coverage 95.71% 95.47% -0.25% 
==========================================
Files 14 14 Lines 1422 1457 +35 Branches 147 149 +2 ==========================================
+ Hits 1361 1391 +30 - Misses 40 44 +4 - Partials 21 22 +1
Impacted FilesCoverage Δ
pyhive/tests/test_hive.py97.7% <ø> (ø)⬆️
pyhive/tests/test_presto.py96.36% <ø> (-3.64%)⬇️
pyhive/tests/test_sqlalchemy_hive.py100% <100%> (ø)⬆️
pyhive/presto.py94% <100%> (+0.38%)⬆️
pyhive/tests/test_sqlalchemy_presto.py100% <100%> (ø)⬆️
pyhive/sqlalchemy_presto.py91.97% <95.45%> (+0.59%)⬆️
pyhive/hive.py90.09% <0%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68e1a8...85ebb50. Read the comment docs.

@devinstevenson
devinstevensonforce-pushed the support-presto-decimal-type branch 2 times, most recently from bf5a6fd to 26e948fCompareNovember 21, 2017 17:46
alter col_type renaming for decimal to not clobber other col_types
use Presto types for sqlalchemy _type_map
update tests for new type handling
add date column for tests
fix missing comma
use raw regex pattern
change doc
@devinstevenson
devinstevensonforce-pushed the support-presto-decimal-type branch from 26e948f to 85ebb50CompareNovember 21, 2017 18:07
@serenajiangserenajiang mentioned this pull request Mar 7, 2022
@CLAassistant

CLAassistant commented Apr 16, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devinstevenson@codecov-io@CLAassistant@dstevenson-lc