Uh oh!
There was an error while loading. Please reload this page.
Problem: TOP_DIR_x are global - #112
Open
gotcha wants to merge 2 commits into
Open
Conversation
Solution: allow it to fail, following gvanrossum recommendation to stop supporting 3.5
Solution: make an API that avoids globals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of @gvanrossum comment on #111, I looked a bit closer to the globals
TOP_DIR_x.IMHO, it is not needed to keep them global.
This PR would replace #111. (Nevertheless, I fixed#111 in order to let you decide which one you prefer.)
The code in this PR enables customizing the
default_filter_filenametop_dirwith the following code: