Skip to content

Bump mypy to 1.6.1 - #1710

Closed
sobolevn wants to merge 1 commit into
masterfrom
mypy-1.6.1
Closed

Bump mypy to 1.6.1#1710
sobolevn wants to merge 1 commit into
masterfrom
mypy-1.6.1

Conversation

@sobolevn

Copy link
Copy Markdown
Member

Closes#1709

@codecov

codecovBot commented Oct 19, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7f025d8) to head (be04f3e).
Report is 184 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1710 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 80 80 Lines 2485 2485 Branches 437 437 =========================================
Hits 2485 2485 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andersk

Copy link
Copy Markdown

Bisecting mypy shows that both failures were first triggered by python/mypy@14418bc:

@sobolevn

Copy link
Copy Markdown
MemberAuthor

Yeap, I have to rework how detach_callable works now.

@thepabloaguilar

Copy link
Copy Markdown
Member

Hey @sobolevn, I can take this to fix!

@sobolevn

Copy link
Copy Markdown
MemberAuthor

Sure, please, go ahead :)

@thepabloaguilar

Copy link
Copy Markdown
Member

I've tried but I have no idea 😄

Why do you think detach_callable is the problem?

@sobolevn

Copy link
Copy Markdown
MemberAuthor

yes :)

@sobolevnsobolevn mentioned this pull request Jun 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@andersk@thepabloaguilar