Skip to content

chore(tholos-v2): emit Revealed events in open_reveal_phase (fixes #156) - #186

Closed
ZacLou wants to merge 1 commit into
drydocs:mainfrom
ZacLou:grantfox-bot/chore-issue-156-20260905-160529
Closed

ZacLou wants to merge 1 commit into
drydocs:mainfrom
ZacLou:grantfox-bot/chore-issue-156-20260905-160529

Conversation

@ZacLou

@ZacLou ZacLou commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Addresses #156

此 PR 由 GrantFox Task Executor 自动生成。

原始 issue: #156

说明:
open_reveal_phase auto-reveals asserter and disputer fixed positions but never emitted Revealed events for them, while explicit reveal() calls do. Indexers relying solely on Revealed events would miss these two guaranteed positions.

Changes:

  • Emit one Revealed event per fixed position inside open_reveal_phase's loop, using the existing Revealed event struct and each voter's agrees_with_asserter value as choice.

Auto-generated by GrantFox Task Executor

…ydocs#156)

open_reveal_phase auto-reveals asserter and disputer fixed positions
but never emitted Revealed events for them, while explicit reveal()
calls do. Indexers relying solely on Revealed events would miss these
two guaranteed positions.\n
Emit one Revealed event per fixed position inside open_reveal_phase's
loop, using the existing Revealed event struct and each voter's
agrees_with_asserter value as choice.\n
Addresses drydocs#156
@collinsezedike

Copy link
Copy Markdown
Collaborator

@ZacLou Closing. #156 has no assignee, so this is premature regardless. Separately, this PR's body states it was automatically generated by a GrantFox Task Executor tool, not written by you. Automated tool submissions attributed to your account are not acceptable here; a PR needs to represent your own work on an issue you've actually been assigned.

@ZacLou

ZacLou commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

@collinsezedike I want to sincerely apologize for the PRs that violated your contribution guidelines.

Three things went wrong:

  1. PRs chore(tholos-v2): emit Revealed events in open_reveal_phase (fixes #156) #186, chore(tholos-v2): emit Revealed event on auto-reveal path #187, and fix(resolve): prevent resolver from voting on their own case #188 were opened on issues ([Chore] Missing Revealed event on tholos-v2's auto-reveal path #156, [Bug] resolve doesn't prevent a resolver from voting on their own case #165) that had no assignee — I should have waited for assignment before opening any PR.
  2. PR bodies contained language indicating they were generated by an automated tool, which you have clearly stated is not acceptable.
  3. After you closed chore(tholos-v2): emit Revealed events in open_reveal_phase (fixes #156) #186 and explained the rules, I should have acknowledged and stopped immediately rather than continuing to push on related issues.

This was my mistake. I have read the CONTRIBUTING guidelines and understand the workflow: comment to request assignment, wait for the GrantFox bot to assign, then open a PR that represents my own work.

Going forward:

  • I will only open PRs on issues that have been formally assigned to me.
  • No automated tooling will be used to generate or submit PRs to any drydocs repository.
  • Each PR will be scoped to exactly one issue with a clean branch.

I respect the work you and the drydocs team are doing. The remaining open PRs (#184 and #185) were opened after proper assignment and are waiting for your re-review. I will not open any new PRs in this organization without following the correct process.

Again, I apologize for the disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants