Support issue previews when a dup task on page - #124
Merged
Conversation
When the same task shows up twice on the user's dashboard, it uses the same turbo frame. So if the user clicks the second task link, the issue previews are always added to the first one on the page. I prepended the turbo frame tag with a unique container name that can be used by the turbo stream view. Fixes Task#83
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the same task shows up twice on the user's dashboard, it uses the same turbo frame. So if the user clicks the second task link, the issue previews are always added to the first one on the page. I prepended the turbo frame tag with a unique container name that can be used by the turbo stream view.
Fixes Task#83