Fix reply timeouts - #37
Conversation
dsrees
commented
Feb 21, 2019
I'm not 100% sure that this is correct. Let me look into this a little further |
dustinconrad
commented
Mar 2, 2019
@dsrees is there anything I can do here to get this moving? Right now I have a hack in place to manually catch the timeout event that is being missed buy the library: |
dsrees
left a comment
There was a problem hiding this comment.
@dustinconrad sorry for not being able to get to this sooner. I dug more into this and your solution is correct. I just wanted to double check. Made a small syntax change request and then i can get this merged and released today
| refEvent?.let { | ||
| val message = PhxMessage(it, "", "", mutPayload) | ||
| val message = PhxMessage(it, "", it, mutPayload) |
There was a problem hiding this comment.
Let's make a change to clean this up a bit and then it should be good to go
refEvent?.let { safeRefEvent ->val message =PhxMessage("", "", safeRefEvent, mutPayload)
this.channel.trigger(message)
}There was a problem hiding this comment.
I fixed it up but opted to use named parameters instead of passing in the empty string for two of them
This should fix issue #36