Skip to content

Refactor Channel Rejoins - #63

Merged
dsrees merged 2 commits into
masterfrom
dr/refactor-rejoins
Jun 20, 2019
Merged

Refactor Channel Rejoins#63
dsrees merged 2 commits into
masterfrom
dr/refactor-rejoins

Conversation

@dsrees

Copy link
Copy Markdown
Owner
  • Rejoin channels whenever a socket opens

@dsrees
dsreesforce-pushed the dr/refactor-rejoins branch from 288be3b to 0dd8418CompareJune 20, 2019 18:18
@codecov-io

codecov-io commented Jun 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #63 into master will increase coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@ Coverage Diff @@## master #63 +/- ##
============================================
+ Coverage 91.23% 91.32% +0.08% + Complexity 179 177 -2 
============================================
Files 9 9 Lines 525 530 +5 Branches 69 71 +2 ============================================
+ Hits 479 484 +5 + Misses 14 13 -1 - Partials 32 33 +1
Impacted FilesCoverage ΔComplexity Δ
src/main/kotlin/org/phoenixframework/Defaults.kt100% <ø> (+9.09%)4 <0> (-1)⬇️
src/main/kotlin/org/phoenixframework/Channel.kt94.96% <77.77%> (-1.09%)53 <1> (-1)
src/main/kotlin/org/phoenixframework/Socket.kt92.59% <0%> (+0.61%)70% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93064af...0dd8418. Read the comment docs.

@dsrees
dsrees merged commit caf94bc into masterJun 20, 2019
@dsrees
dsrees deleted the dr/refactor-rejoins branch June 20, 2019 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dsrees@codecov-io