Uh oh!
There was an error while loading. Please reload this page.
Fix : aggregate method typing to accept list of expressions - #246
Merged
evertlammerts merged 2 commits intoJan 6, 2026
Merged
Conversation
evertlammerts
commented
Jan 5, 2026
Member
Thanks, LGTM! Can you rebase on v1.4-andium? |
Narwhal-fish
commented
Jan 6, 2026
ContributorAuthor
Sure! |
Narwhal-fishforce-pushed
the
fix-DuckDBPyRelation.aggregate-incorrect-typing
branch
from
January 6, 2026 05:31
90f4b3c to
f2bc4faCompareevertlammertsforce-pushed
the
fix-DuckDBPyRelation.aggregate-incorrect-typing
branch
from
January 6, 2026 09:35
f2bc4fa to
b845b35Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#209
The type stub for
DuckDBPyRelation.aggregateincorrectly restricts theaggr_exprparameter toExpression | str. However, the DuckDB Python APIand runtime behavior also support passing a list of
Expressionobjects formultiple aggregations.
The fix extends the type annotation to include
list[Expression], aligningthe stub definition with the actual supported API behavior.