Uh oh!
There was an error while loading. Please reload this page.
fix(e6): strip all comments in transpiler output to avoid parse breakage - #289
Open
tkaunlaky-e6 wants to merge 1 commit into
Open
fix(e6): strip all comments in transpiler output to avoid parse breakage#289tkaunlaky-e6 wants to merge 1 commit into
tkaunlaky-e6 wants to merge 1 commit into
Conversation
Databricks queries with `--` comments between clauses failed transpilation. sqlglot rewrites each `--` into an inline `/* */` block and attaches it to the nearest node, so a CTE renders as `period_dates /* .. */ AS (...)` -- the comment wedged between the alias and AS, which the E6 parser rejects. The existing strip_comment() only removed /* */ blocks (regex), never `--`. sanitize_comments now drops every comment at the AST level (safe for string literals) before generation, so no stray comment reaches the engine. E6 SKIPs `--`/`//` comments in its lexer anyway, so nothing of value is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Databricks queries with
--comments between clauses failed transpilation. sqlglot rewrites each--into an inline/* */block and attaches it to the nearest node, so a CTE renders asperiod_dates /* .. */ AS (...)-- the comment wedged between the alias and AS, which the E6 parser rejects. The existing strip_comment() only removed /* */ blocks (regex), never--.sanitize_comments now drops every comment at the AST level (safe for string literals) before generation, so no stray comment reaches the engine. E6 SKIPs
--///comments in its lexer anyway, so nothing of value is lost.