Skip to content

Enhanced Thread Pool Implementation - #304

Open
jparisu wants to merge 5 commits into
mainfrom
feature/enchance-thread-pool
Open

Enhanced Thread Pool Implementation#304
jparisu wants to merge 5 commits into
mainfrom
feature/enchance-thread-pool

Conversation

@jparisu

@jparisujparisu commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

New Enchanced Thread Pool Implementation with following characteristics:

  • Better performance (it is supposed to)
  • Easier to use
  • Support arguments

It requires #270

@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from 2ef81a5 to ae123f2CompareSeptember 19, 2022 07:57
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from ae123f2 to 19540d2CompareSeptember 19, 2022 14:19
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from 19540d2 to c8fd30aCompareSeptember 20, 2022 05:29
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from c8fd30a to c8bfd93CompareSeptember 20, 2022 07:44
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from c8bfd93 to 3c9d470CompareSeptember 20, 2022 13:46
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from 3c9d470 to 80f71cbCompareSeptember 20, 2022 13:58
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from 80f71cb to 5d60381CompareSeptember 20, 2022 14:06
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:06 Inactive
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:06 Inactive
@jparisu
jparisu marked this pull request as ready for review September 20, 2022 14:06
jparisu added 3 commits September 20, 2022 16:07
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisuforce-pushed the feature/enchance-thread-pool branch from 5d60381 to eb0290aCompareSeptember 20, 2022 14:07
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:07 Inactive
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:07 Inactive
@jparisujparisu changed the title TMP Thread Pool ImplementationEnchanced Thread Pool ImplementationSep 20, 2022
@codecov

codecovBot commented Sep 20, 2022

Copy link
Copy Markdown

Codecov Report

Base: 53.19% // Head: 53.76% // Increases project coverage by +0.57% 🎉

Coverage data is based on head (b8b7bbf) compared to base (3a215f6).
Patch coverage: 68.34% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@## main #304 +/- ##
==========================================
+ Coverage 53.19% 53.76% +0.57% 
==========================================
Files 104 121 +17 Lines 3848 3980 +132 Branches 1413 1467 +54 ==========================================
+ Hits 2047 2140 +93 + Misses 998 995 -3 - Partials 803 845 +42 
Impacted FilesCoverage Δ
...clude/ddsrouter_utils/wait/ConsumerWaitHandler.hpp0.00% <ø> (ø)
...lude/ddsrouter_utils/thread/task/ArgsOwnedTask.hpp50.00% <50.00%> (ø)
.../ddsrouter_utils/thread/task/ArgsReferenceTask.hpp50.00% <50.00%> (ø)
.../ddsrouter_utils/wait/impl/ConsumerWaitHandler.ipp75.00% <50.00%> (-9.22%)⬇️
...e/ddsrouter_utils/wait/impl/DBQueueWaitHandler.ipp35.71% <50.00%> (-8.74%)⬇️
...uter_utils/src/cpp/thread/manager/AsyncManager.cpp50.00% <50.00%> (ø)
...ter_utils/src/cpp/thread/manager/StdThreadPool.cpp50.00% <50.00%> (ø)
...router_utils/src/cpp/thread/task/ReferenceTask.cpp66.66% <66.66%> (ø)
...r_utils/thread/connector/impl/OneShotConnector.ipp71.42% <71.42%> (ø)
...uter_utils/thread/connector/impl/SlotConnector.ipp80.00% <80.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:27 Inactive
@jparisu
jparisu temporarily deployed to codecov September 20, 2022 14:27 Inactive
@jparisujparisu changed the title Enchanced Thread Pool ImplementationEnhanced Thread Pool ImplementationSep 21, 2022
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov September 27, 2022 15:14 Inactive
@jparisu
jparisu temporarily deployed to codecov September 27, 2022 15:14 Inactive
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jparisu