Skip to content

fix(main): derive harness binaries from all install methods - #43

Merged
johnnyhuy merged 1 commit into
mainfrom
fix/harness-binary-discovery
Aug 22, 2026
Merged

fix(main): derive harness binaries from all install methods#43
johnnyhuy merged 1 commit into
mainfrom
fix/harness-binary-discovery

Conversation

@johnnyhuy

Copy link
Copy Markdown
Contributor

Summary

  • Claude Code was reported as "not installed" despite being installed (Homebrew cask at /opt/homebrew/bin/claude).
  • Root cause: discoverHarnesses derived the binary name from installMethods[0] only, falling back to the catalog id. Claude Code's first install method is brew (no binary field), so discovery searched PATH for claude-code instead of claude. Codex only worked by coincidence (id == binary name).
  • Fix: collect binary names from all install methods, dedupe, fall back to the catalog id.

Consequences

  • None — strictly widens discovery. Harnesses whose binary name differs from their catalog id (or that install via brew first) are now detected.

Testing

  • npm run typecheck, npm run lint
  • ✓ Verified locally: which -a claude finds /opt/homebrew/bin/claude (cask 2.1.224); app now detects Claude Code as installed after relaunch.

discoverHarnesses only read installMethods[0] for the binary name and
fell back to the catalog id. Claude Code's first method is brew (no
binary field), so discovery searched PATH for 'claude-code' instead of
'claude' and reported an installed harness as missing.
Co-authored-by: opencode-agent[bot] <219766164+opencode-agent[bot]@users.noreply.github.com>
@johnnyhuy
johnnyhuy enabled auto-merge (squash) August 22, 2026 13:33
@johnnyhuy
johnnyhuy merged commit e617778 into mainAug 22, 2026
7 checks passed
@johnnyhuy
johnnyhuy deleted the fix/harness-binary-discovery branch August 22, 2026 13:33
@github-actionsgithub-actionsBot mentioned this pull request Aug 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@johnnyhuy