Skip to content

ui: tenant-selection.html border-destructive is undefined in Harmonia 2.14.2, and #7200 documents a #defaultLiteral macro #7205 had just deleted #7243

Description

@delchev

Summary

Two leftovers from the 09:30-09:36 merge burst on 2026-09-09.

1. tenant-selection.html still uses an undefined Harmonia class. components/security/security-oauth2/src/main/resources/static/tenant-selection.html:93:

<div x-show="error" role="alert" class="rounded-md border border-destructive p-4 text-sm"

Harmonia 2.14.2 (the version the root pom pins; dist/harmonia.css + harmonia-extend.css in the codbex__harmonia webjar) defines no border-destructive / text-destructive / bg-destructive rule at all - border-negative is the token. Same defect class as #7155, whose PR (#7204) fixed the four required markers and wrote "left for its own issue" for this one; no such issue exists. The error box renders with the default border colour.

2. Three references to a macro that no longer exists. #7205 (0f05ec5d, 09:30:53) deleted #macro(defaultLiteral ...) from Repository.java.template (the unquoting now lives in JavaLiterals.unquote / ModelParameterProcessor.resolveDefaultValueLiteral). #7200 (932ffb2f, 09:31:56) then added three references to it:

  • engine-intent/.../generator/NumberingSupport.java:81-82 - "so it needs no unquoting the way the DAO template's #defaultLiteral does for a field default"
  • engine-intent/src/test/.../NumberingInitPartitionTest.java:63 - same sentence
  • components/engine/engine-intent/CLAUDE.md:403 - same sentence

git grep -n defaultLiteral origin/master finds only these (plus one pre-existing mention in GlueIntentGenerator.java:2761); no template defines it.

Also from #7204: HarmoniaRequiredMarkerIT.java:79 checks marker.contains("text-negative") over the whole class attribute, so a drift to text-negative-foreground (a defined class - the on-negative text colour, near-white on light) passes; split on whitespace and compare tokens.

Found reviewing #7200, #7204, #7205.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions