Skip to content

Update model to use transient data for ID references - #463

Merged
TruongQuangSB merged 6 commits into
mainfrom
transient-model
Apr 9, 2024
Merged

Update model to use transient data for ID references#463
TruongQuangSB merged 6 commits into
mainfrom
transient-model

Conversation

@pstuecker

@pstueckerpstuecker commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

This replaces the current approach of a (mostly autogenerated) model-to-model transformation (model <-> toolboxmodel) by adding transient attributes to the EMF model.

For the set repo there are a lot of changes:

  • org.eclipse.set.toolboxmodel is changed to org.eclipse.set.model.planpro
  • Accessing objects from ID references now requires a call to the getValue()-function
  • Toolboxmodel has been removed
  • ID references are being resolved on load
  • The modelservice and related functionality has been migrated to set

@pstuecker
pstuecker marked this pull request as draft March 21, 2024 09:10
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Mar 21, 2024•
edited
Loading

Copy link
Copy Markdown

Test Results

23 tests 23 ✅ 0s ⏱️
9 suites 0 💤
9 files 0 ❌

Results for commit 14cb816.

♻️ This comment has been updated with latest results.

@pstuecker
pstuecker marked this pull request as ready for review March 22, 2024 14:42
TruongQuangSB
TruongQuangSB requested changes Mar 25, 2024
View reviewed changes
Comment thread...set.feature.plazmodel/src/org/eclipse/set/feature/plazmodel/check/PlanungsBereichValid.xtend Outdated
Comment thread...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/ssld/SsldTransformator.xtend
Comment thread...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/sslr/SslrTransformator.xtend
Comment thread...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/sslw/SslwTransformator.xtend
Comment thread...ipse.set.feature.validation/src/org/eclipse/set/feature/validation/session/ModelSession.java
Comment threadjava/bundles/org.eclipse.set.feature/feature.xml
Comment thread...model.extensions/src/org/eclipse/set/ppmodel/extensions/PlanProSchnittstelleExtensions.xtend Outdated
Comment thread...model.extensions/src/org/eclipse/set/ppmodel/extensions/PlanProSchnittstelleExtensions.xtend Outdated
@TruongQuangSB

This comment was marked as resolved.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
TruongQuangSB
TruongQuangSB reviewed Apr 9, 2024
View reviewed changes
Comment threadjava/bundles/org.eclipse.set.unittest.utils/META-INF/MANIFEST.MF Outdated
TruongQuangSB
TruongQuangSB reviewed Apr 9, 2024
View reviewed changes
Comment threadjava/bundles/org.eclipse.set.feature.siteplan.test/META-INF/MANIFEST.MF Outdated
pstueckerand others added 2 commits April 9, 2024 12:33
@pstuecker@TruongQuangSB
Update java/bundles/org.eclipse.set.unittest.utils/META-INF/MANIFEST.MF
7f03303
Co-authored-by: TruongQuangSB <131350493+TruongQuangSB@users.noreply.github.com>
@pstuecker@TruongQuangSB
Update java/bundles/org.eclipse.set.feature.siteplan.test/META-INF/MA…
594aa39
…NIFEST.MF
Co-authored-by: TruongQuangSB <131350493+TruongQuangSB@users.noreply.github.com>
@TruongQuangSB
TruongQuangSB merged commit 39ae194 into mainApr 9, 2024
@TruongQuangSB
TruongQuangSB deleted the transient-model branch April 9, 2024 10:34
@github-actions

This comment has been minimized.

Sign in to view
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TruongQuangSBTruongQuangSBTruongQuangSB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pstuecker@TruongQuangSB