Uh oh!
There was an error while loading. Please reload this page.
api: fix typedefs to known length - #23
Conversation
Signed-off-by: LE/Jiri Novotny <jiri.novotny@logicelements.cz>
jiri-novotny
commented
Sep 7, 2023
@microsoft-github-policy-service agree |
miracoli
commented
Jul 28, 2026
The fixed-width typedefs are reasonable for LevelX media data, but the current patch mixes media-word width and pointer width. After this change: typedefuint32_tULONG;
#defineALIGN_TYPE ULONG
This should not be applied indiscriminately: calculations describing LevelX flash words must continue to use The NOR and NAND simulators also still store flash words as I would suggest extending the PR to:
|
fdesbiens
commented
Jul 28, 2026
@miracoli I agree with you this is a useful fix. The issue is that this is an old PR predating the move of the codebase to Eclipse. So, I cannot merge it without the original author signing the ECA. @jiri-novotny If you are still around, would you mind following the instructions below to sign the ECA, please? @miracoli If the original author does not respond, an alternative would be submitting your own PR. @jiri-novotny: Before accepting your contribution, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record. Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org. Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Also, please add your GitHub ID to your Eclipse account. This enables synchronisation between Eclipse-owned infrastructure and GitHub. Here is the link to sign the ECA: |
jiri-novotny
commented
Jul 30, 2026
Hi, I have signed ECA and linked Eclipse account with Github. |
all internal ULONG compares are defined in 32b e.g.
where
this change maps internal types to known-length types from <stdint.h>