Skip to content

Switch eccodes python to wheelchains - #114

Open
tmi wants to merge 8 commits into
developfrom
project/wheelify
Open

Switch eccodes python to wheelchains#114
tmi wants to merge 8 commits into
developfrom
project/wheelify

Conversation

@tmi

@tmitmi commented Dec 12, 2024

Copy link
Copy Markdown

Switching the eccodes python package to rely on wheelchain -- in particular, the wheel produced in ecmwf/eccodes#277

The changes are in short:
1/ switching the wheel build to be done in a docker with common tooling present
2/ pulling the wheel with binary eccodes at buildtime and using it for lib/include
3/ updating the findlibs call at runtime to find the right .so

What is (currently) missing:
1/ add a dep lowerbound to findlibs (ecmwf/findlibs#14 -- not released yet)
2/ switch from test pypi to real one (nothing published yet)
3/ add in full matrix over python versions, platforms, etc

@FussyDuck

FussyDuck commented Dec 12, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@dimbleby

Copy link
Copy Markdown

#103 (comment)

@tmi
tmiforce-pushed the project/wheelify branch 2 times, most recently from d2448fa to 815ccafCompareDecember 16, 2024 12:18
@tmi
tmiforce-pushed the project/wheelify branch 11 times, most recently from e32d2c9 to ef5b847CompareMay 19, 2025 14:00
@tmi
tmiforce-pushed the project/wheelify branch from ef5b847 to d700baeCompareMay 19, 2025 14:01
@tmi
tmi marked this pull request as ready for review May 26, 2025 08:38
@shahramnshahramn self-assigned this Jun 2, 2025
@tmi
tmiforce-pushed the project/wheelify branch 3 times, most recently from b5373ff to 7d9973aCompareJune 3, 2025 07:03
@tmi
tmiforce-pushed the project/wheelify branch from 7d9973a to bb9efbfCompareJune 3, 2025 07:23
@codecov-commenter

codecov-commenter commented Jun 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 32.74%. Comparing base (23005cc) to head (43c2737).
Report is 1 commits behind head on develop.

Files with missing linesPatch %Lines
setup_windows.py0.00%44 Missing ⚠️
setup.py0.00%21 Missing ⚠️
gribapi/bindings.py0.00%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #114 +/- ##
===========================================
- Coverage 33.15% 32.74% -0.41% 
===========================================
Files 16 17 +1 Lines 2645 2678 +33 Branches 190 194 +4 ===========================================
Hits 877 877 - Misses 1752 1785 +33 
Partials 16 16 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmi
tmiforce-pushed the project/wheelify branch from 0116510 to 43c2737CompareJune 3, 2025 08:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tmi@FussyDuck@dimbleby@codecov-commenter@shahramn