Skip to content

Serial port manual configurable - #27

Merged
ecto merged 6 commits into
ecto:masterfrom
setola:master
Jul 24, 2013
Merged

Serial port manual configurable#27
ecto merged 6 commits into
ecto:masterfrom
setola:master

Conversation

@setola

Copy link
Copy Markdown
Contributor

Hello,
I've added this feature to your project cause my arduino was on /dev/ttyACM0 and the library was not able to detect it.

Thank you for your work, it's awesome!
Keep it going!

@nmec

nmec commented Oct 30, 2012

Copy link
Copy Markdown

Thanks for posting this, got things working for me in Ubuntu. Hope this can be merged soon.

@flosse

Copy link
Copy Markdown

+1

Comment threadREADME.md Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the example, this will connect to /dev/ACM? I think this could be a little more clear.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in the example the library searches for Arduino in every device that has 'ACM' string in its name.

A better documentation maybe:

The board library will attempt to autodiscover the Arduino.
Here you can set a regex filter to limit the library scan only matching devices.
It uses grep syntax.
If this parameter is empty the board library will attempt to autodiscover the Arduino by quering every device containing 'usb' in its name.

@ecto

ecto commented Dec 7, 2012

Copy link
Copy Markdown
Owner

Hey guys, I don't have my Arduino right now (it's halfway across the country). Can you confirm that this patch is legit? Also @setola, could you clarify the README section I commented on? I'll push this to npm afterward!

@ecto

ecto commented Dec 7, 2012

Copy link
Copy Markdown
Owner

Also it appears there is a merge conflict after merging #26 😣

@setola

Copy link
Copy Markdown
ContributorAuthor

I think that the conflict on #26 is because i forked the project before the #26 was committed.

@setola

Copy link
Copy Markdown
ContributorAuthor

Conflict should be solved on 99dc318 commit, I've also improved documentation of 'device' parameter.
Hope notthing is missing...

cheers

@bigmonkeyboy

Copy link
Copy Markdown

This works really well... +1 to merge.

@anpross

Copy link
Copy Markdown

oh well - should have checked the pull requests first - i just build my own patch to fix the same problem...

@poul-kg

Copy link
Copy Markdown

Why fixes by @setola are still not merged? Is this project dead?

@setola

Copy link
Copy Markdown
ContributorAuthor

try to ping @ecto to see if he's not so busy as usually :) :)
👍

ecto pushed a commit that referenced this pull request Jul 24, 2013
Serial port manual configurable
@ecto
ecto merged commit cf4421e into ecto:masterJul 24, 2013
@ecto

ecto commented Jul 24, 2013

Copy link
Copy Markdown
Owner

Merged and pushed to npm @ 0.0.9. Thanks @setola!

@setola

Copy link
Copy Markdown
ContributorAuthor

again a big thank for your work @ecto
grats for the new version!!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@setola@nmec@flosse@ecto@bigmonkeyboy@anpross@poul-kg