Remotes/upstream/v0.12.1.x triggers - #6
Merged
eduffield222 merged 6 commits intoAug 8, 2016
Merged
Conversation
added 6 commits
August 6, 2016 11:28
- Fixed LogPrint bug in CSuperblock::IsValid
trigger manager access is now protected only by the governance.cs mutex - Removed unsafe caching of govobj pointer in CSuperblock - Moved status from map to CSuperblock - Reduced width of public interfaces to CTriggerManager and CSuperblockManager - Implemented removal of executed and invalid (but not expired) triggers - Reordered CSporkMessage members to avoid structure padding (note serialization format is unchanged) - Replaced X11 hash with CHashWriter for CSporkMessage
now causes the removal of the underlying govobj - Added many LOCK(governance.cs) calls to hopefully make access to CGovernanceManager safe. This needs heavy testing or better yet static analysis to guarantee correctness. Deadlock conditions cannot yet be excluded.
…to remotes/upstream/v0.12.1.x-triggers Merged change from upstream.
- Implemented caching of block height in CGovernanceManager to avoid possible deadlock between cs_main and governance.cs mutexes - Implemented expiration of unexecuted triggers approximately one month after their scheduled trigger time (per Evan's request) - Removed unused chain tip pointer in rpcgovernance.cpp. Fixes compiler warning and avoids an unnecessary lock on cs_main.
eduffield222
commented
Aug 8, 2016
Owner
looks great, I'm going to merge this then start working on merging all of this upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily includes trigger/govobj removal after execution (but not yet time based expiration) and many mutex locking changes.