Uh oh!
There was an error while loading. Please reload this page.
refactor(vue): remove tanstack query engine, atom is the only backend - #813
Open
patroza wants to merge 2 commits into
Open
refactor(vue): remove tanstack query engine, atom is the only backend#813patroza wants to merge 2 commits into
patroza wants to merge 2 commits into
Conversation
- Drop @tanstack/vue-query deps and patches/@tanstack__query-core.patch - Delete packages/vue/src/internal/tanstackQuery.ts - makeClient drops legacyQueryEngine option and tanstackQueryClient return - QueryImpl no longer takes legacyUseQuery override - Convert tanstack-only tests to the atom path BREAKING CHANGE: makeClient no longer accepts MakeClientOptions / legacyQueryEngine; the Atom engine is the sole query backend.
@effect-app/clieffect-app@effect-app/eslint-codegen-model@effect-app/eslint-shared-config@effect-app/infra@effect-app/vue@effect-app/vue-componentscommit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the TanStack query engine entirely, leaving the Effect
Atomengine as the sole query backend. The Atom engine already provided every feature the tanstack path did (cache identity, SWR + focus revalidation, gcTime, retry, structural sharing, hierarchical invalidation, read-dependency derivation).Changes
@tanstack/vue-query/@tanstack/query-coredependencies andpatches/@tanstack__query-core.patch.packages/vue/src/internal/tanstackQuery.ts(makeTanstackQuery,makeTanstackQueryClient,makeTanstackQueryInvalidator,makeTanstackQueryCacheUpdater).makeClientno longer acceptslegacyQueryEngineand no longer returnstanstackQueryClient; theMakeClientOptionsinterface is removed.QueryImplno longer takes alegacyUseQueryoverride —.query()/.suspense()now always run on the Atom engine alongside.atom()/.family()/.queryNew()/.suspenseNew().Tests
vue/test/query-span.test.ts— dropped the tanstack span test (atom test retained).vue/test/suspense-regression.test.ts— both tests were tanstack-only; converted the structural-sharing test to the atom path (viawithQueryOptions), dropped the tanstack key-race regression.vue/test/dependencyInvalidation.test.ts— dropped the tanstack recording/eviction/matrix tests; atom tests and the atom invalidation matrix retained.e2e/test/repoInvalidation.e2e.test.ts— dropped the tanstack engine e2e; atom engine e2e retained.vue/test/makeClient.test.ts— thecombineQueryInvalidatorstest is left as-is (it tests the combiner with two fake invalidators, not the tanstack engine).Validation
pnpm check✅pnpm lint-fix✅pnpm --filter @effect-app/vue test run✅ (83 passed, 2 skipped)pnpm --filter @effect-app/e2e test run✅Breaking change
makeClientno longer acceptsMakeClientOptions/legacyQueryEngine; callers that passed{ legacyQueryEngine: "tanstack" }must drop the argument. The Atom engine is the sole backend.Changeset
@effect-app/vue: minor@effect-app/e2e: patch