Emit effect-app schema facades at .d.ts (parity with tsc) by patroza · Pull Request #2 · effect-app/typescript-go

patroza · 2026-06-21T20:03:03Z

Port the effect-app schema facade declaration emit to typescript-go.
(we actually apply on top of effect's tsgo fork effect-app/tsgo#1)

What changes:

Emits compact facade-shaped declarations for effect-app schema classes and struct schema values.
Adds resolver support for serializing class schema static property types as type literals.
Normalizes generated import types so existing namespace imports are preferred before falling back to import("...") type references.
Replaces legacy Encoded extends S.StructNestedEncoded<typeof SameModel> placeholders by materializing the parsed heritage type directly, matching the TypeScript emitter path.

Validation against scanner:

Built and published release binaries as effect-app/tsgo@v0.14.5-effect-app.4 from this PR head (49e73f3).
Installed scanner with the .4 release and ran ./node_modules/.bin/tsgo --version: Version 0.14.5-effect-app.4.
Ran scanner API declaration build with MACS_TS_COMPILER=tsgo node scripts/tsgo-or-tsc.mjs --build api/tsconfig.src.json --force --stopBuildOnErrors --singleThreaded.
Result: build passes and api/dist has 0 remaining StructNestedEncoded placeholders, matching patched tsc.

Four-way scanner comparison:

patched tsc: passes, 0 placeholders, ~47s wall
patched tsgo .4 single-threaded: passes, 0 placeholders, ~16.5s wall
stock TypeScript 6.0.3: passes, 244 placeholders
stock tsgo single-threaded: passes, 244 placeholders

Remaining tsc-vs-tsgo declaration differences are the existing printer/type-serialization drift: union/member ordering, import qualifier choices, and .tsbuildinfo/map churn. The schema placeholder behavior is now on par.

Shipped via the Effect language-service tsgo

This PR is the canonical facade-emit implementation. It is regenerated verbatim into the Effect language-service tsgo as _patches/029-031 in effect-app/tsgo#1 — that LS-enabled build is what macs/scanner actually downloads (binary carries both the Effect LSP and these facades).

Keep in sync: when this PR's head changes, regenerate effect-app/tsgo _patches/029-031 from it (same upstream base commit dc37b524, so the diff applies directly).

Port PR: _patches: layer the .d.ts-emit schema-facade emitter onto Effect-TS/tsgo tsgo#1
Released binary 7.0.0-dev+effect-app.5: https://github.com/effect-app/tsgo/releases/tag/v7.0.0-dev-effect-app.5

Re-expresses our effect-app/typescript-go#2 feature (class/error/struct schema facade declaration emit) as three `_patches/` entries, authored against the exact `typescript-go` submodule commit this repo pins (dc37b5249) — the same commit our codex baseline branched from, so they apply cleanly: 029-transformers-declarations-effect-schema.patch (declaration transformer) 030-checker-emitresolver-effect-schema.patch (CreateTypeOf* resolver) 031-printer-emitresolver-effect-schema.patch (EmitResolver interface) The feature is purely additive (no overlap with Effect patches 001-028). After `setup-repo` applies 001-031 and regenerates diagnostics, `go build ./cmd/tsgo` yields a tsgo with Effect's LSP hooks AND our .d.ts emitter. Verified on the macs/scanner src tree: 0 errors, 145 Effect LSP diagnostics (hooks live), and 56 StructFacade + 10 OpaqueClassFacade + 46 OpaqueErrorFacadeClass (emitter live). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…ffect-app.5 Regenerate the .d.ts schema-facade patches verbatim from the canonical Go implementation in effect-app/typescript-go PR #2 (head a9dd01c, base dc37b524 == this submodule pin), restoring four improvements the earlier partial port dropped: - generated import normalization (prefer namespace imports over import("...")) - legacy `Encoded extends S.StructNestedEncoded` materialization - static-member rewriting (fields -> X.Fields, mapFields/copy signatures) - `Fields` interface in the generated namespace 029 transform.go +920 -> +1148; 030/031 unchanged in substance. Verified against scanner api decl build: exit 0, 0 StructNestedEncoded placeholders, 415 `Fields` interfaces emitted, Effect language service diagnostics live. Set the binary version suffix to semver build metadata on the upstream 7.x base: core.SetVersionSuffix("+effect-app.5") -> `tsgo --version` = 7.0.0-dev+effect-app.5 (replaces the old 0.14.x-effect-app.N scheme). Bump the counter per gz release. Source: effect-app/typescript-go#2 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Mirror effect-app/TypeScript#3 in the Go declaration transformer: detect the schema constructor family from class heritage and emit the matching facade base instead of always S.OpaqueFacade. - S.Class/TaggedClass -> S.OpaqueClassFacade - S.ErrorClass/Tagged... -> S.OpaqueErrorFacadeClass - S.Opaque/OpaqueFacade -> S.OpaqueFacade (unchanged; requests stay here) The brand (6th facade arg) is lifted from the source base when present: the class/error families build on S.EnhancedClass<Self, Schema, Inherited> whose 3rd arg is the brand (e.g. Cause.YieldableError for errors). Opaque keeps {}. Scanner parity with tsc: 46 OpaqueErrorFacadeClass + 10 OpaqueClassFacade, brand preserved, 0 errors, 13 EnhancedClass residual. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Mirror effect-app/TypeScript struct faceting in the Go declaration transformer. A `const X = S.Struct(...)` / `S.TaggedStruct(...)` model is retyped from the giant inline `S.Struct<{...}>` to a compact scanner-local `import("#lib/StructFacade").StructFacade<X, X.Encoded, X.Make, X.DecodingServices, X.EncodingServices, X.Fields>`, with a sibling `interface X` (decoded Self) and a type-only `declare namespace X` (Fields/Encoded/Make/ services). Both are type-space, so they merge with the `const X` value without a value collision; the source's `export type X = typeof X.Type` companion is dropped in favour of the interface. Adds the EmitResolver method CreateTypeOfStructSchemaProperty (reads a property off the const's initializer type and serializes the resolved type, so `never` services stay `never`). Scanner src tree on par with tsc: 56 structs faceted, 0 errors, byte-identical struct emit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Mirror the tsc fix: the facade base is S.Bottom-based, so 'identifier: string' was dropped from faceted class/error models. Add it to the static members. Scanner: 0 errors, identifier present, 10 OpaqueClassFacade + 46 OpaqueErrorFacadeClass + 56 StructFacade unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…erface (parity) Mirror tsc: identifier now on the effect-app facade interfaces; not hand-emitted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Mirror tsc: struct models emit `S.StructFacade<...>` via the file's `S` import (effect-app >= beta.279), not an import-type. Add docs/effect-schema-facade-emit.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Output byte-identical to the tsc fork. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>