Uh oh!
There was an error while loading. Please reload this page.
feat: add ${baseDir}/.node/bin to PATH if exists - #14
Merged
Conversation
atian25
approved these changes
Nov 21, 2017
atian25
reviewed
Nov 23, 2017
| // for nodeinstall | ||
| let newPATH = `${path.join(baseDir, 'node_modules/.bin')}${path.delimiter}`; | ||
| // support `${baseDir}/.node/bin` | ||
| const customNodeBinDir = path.join(baseDir, '.node/bin'); |
Member
There was a problem hiding this comment.
看到了，避免 npm@5 install 将 node_modules 所有文件清空
atian25
commented
Nov 29, 2017
Member
Conflicting 了，要修下 |
atian25force-pushed
the
support-node-dir
branch
from
November 30, 2017 08:08
35bef35 to
2e7b322Compareatian25
commented
Nov 30, 2017
Member
2.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change