Skip to content

feat: npm stop by win32 support - #20

Closed
waitingsong wants to merge 27 commits into
eggjs:masterfrom
waitingsong:win-support
Closed

feat: npm stop by win32 support#20
waitingsong wants to merge 27 commits into
eggjs:masterfrom
waitingsong:win-support

Conversation

@waitingsong

@waitingsongwaitingsong commented Apr 2, 2018

Copy link
Copy Markdown

need egg-cluster patch: eggjs/cluster#63

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov

codecovBot commented Apr 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #20 into master will decrease coverage by 36.54%.
The diff coverage is 10.56%.

Impacted file tree graph

@@ Coverage Diff @@## master #20 +/- ##
===========================================
- Coverage 100% 63.45% -36.55% 
===========================================
Files 6 6 Lines 187 301 +114 ===========================================
+ Hits 187 191 +4 - Misses 0 110 +110
Impacted FilesCoverage Δ
lib/helper.js15.62% <1.81%> (-84.38%)⬇️
lib/cmd/stop.js93.75% <84.61%> (-6.25%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f4125...4c81525. Read the comment docs.

@waitingsong
waitingsongforce-pushed the win-support branch 5 times, most recently from f333fd9 to 3c98bceCompareApril 3, 2018 09:50
@waitingsong

Copy link
Copy Markdown
Author

@atian25 win32 测试写好可以执行 appveyor 测试

@waitingsong

Copy link
Copy Markdown
Author

谁来看看呢

@popomore

Copy link
Copy Markdown
Member

@waitingsong Thx for your work, this feature has been merged in #22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@waitingsong@popomore