Skip to content

refactor: add this.exit to instead of process.exit - #25

Merged
fengmk2 merged 2 commits into
eggjs:masterfrom
NBUT-Developers:this.exit
Aug 10, 2018
Merged

refactor: add this.exit to instead of process.exit#25
fengmk2 merged 2 commits into
eggjs:masterfrom
NBUT-Developers:this.exit

Conversation

@XadillaX

@XadillaXXadillaX commented Aug 10, 2018

Copy link
Copy Markdown
Member
Checklist
  • npm test passes
  • commit message follows commit guidelines
Affected core subsystem(s)

egg-scripts

Description of change

统一管控 process.exit(),这样对于继承的子包有更好的可操控性。

@codecov

codecovBot commented Aug 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #25 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 6 6 Lines 203 204 +1 =====================================
+ Hits 203 204 +1
Impacted FilesCoverage Δ
lib/cmd/start.js100% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ebb30...a61e0a7. Read the comment docs.

@fengmk2
fengmk2 merged commit dac29f7 into eggjs:masterAug 10, 2018
@fengmk2

Copy link
Copy Markdown
Member

2.8.0

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@XadillaX@fengmk2