Skip to content

feat: --no-deprecation - #44

Merged
atian25 merged 1 commit into
masterfrom
no-deprecation
Jun 11, 2021
Merged

feat: --no-deprecation#44
atian25 merged 1 commit into
masterfrom
no-deprecation

Conversation

@atian25

Copy link
Copy Markdown
Member
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

add --no-deprecation as default execArgv to avoid some log like DeprecationWarning: Buffer() is deprecated to stderr which will break startup unnecessary.

@atian25
atian25force-pushed the no-deprecation branch 2 times, most recently from 788f5fc to 2583812CompareJune 11, 2021 06:59
Comment threadlib/cmd/start.js Outdated
@atian25
atian25force-pushed the no-deprecation branch 3 times, most recently from 41ca19a to 6dc0d89CompareJune 11, 2021 07:04
@mansonchor

Copy link
Copy Markdown
Member

CI 跪了

@codecov

codecovBot commented Jun 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #44 (0d8d22f) into master (ad585eb) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

❗ Current head 0d8d22f differs from pull request most recent head 91fbe4b. Consider uploading reports for the commit 91fbe4b to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #44 +/- ##
==========================================
- Coverage 99.52% 99.15% -0.37% 
==========================================
Files 6 6 Lines 209 237 +28 Branches 0 46 +46 ==========================================
+ Hits 208 235 +27 - Misses 1 2 +1 
Impacted FilesCoverage Δ
lib/cmd/start.js99.23% <100.00%> (+0.07%)⬆️
lib/helper.js95.45% <0.00%> (-4.55%)⬇️
index.js100.00% <0.00%> (ø)
lib/command.js100.00% <0.00%> (ø)
lib/cmd/stop.js100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad585eb...91fbe4b. Read the comment docs.

@mansonchormansonchor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atian25
atian25 merged commit f0a342f into masterJun 11, 2021
@atian25
atian25 deleted the no-deprecation branch June 11, 2021 08:41
@licaide

Copy link
Copy Markdown

--no-deprecation 运行 pkg 打包eggjs 执行会报错
如下:
egg-scripts] Starting egg application at /snapshot/pkg-egg3js-example
[egg-scripts] Run node --no-deprecation --trace-warnings /snapshot/pkg-egg3js-example/node_modules/egg-scripts/lib/start-cluster {"no-deprecation":["true",1],"baseDir":"/snapshot/pkg-egg3js-example","framework":"/snapshot/pkg-egg3js-example/node_modules/egg","title":"egg-server-pkg-egg3js-example"} --title=egg-server-pkg-egg3js-example
[egg-scripts] Save log file to /root/logs
[egg-scripts] Wait Start: 1...
[egg-scripts] tail -n 100 /root/logs/master-stderr.log
[egg-scripts] Got error when startup:
[egg-scripts] node:internal/modules/cjs/loader:949
[egg-scripts] throw err;
[egg-scripts] ^
[egg-scripts]
[egg-scripts] Error: Cannot find module '/home/product/node/test_lcd/--no-deprecation'
[egg-scripts] at Module._resolveFilename (node:internal/modules/cjs/loader:946:15)
[egg-scripts] at Function._resolveFilename (pkg/prelude/bootstrap.js:1951:46)
[egg-scripts] at Module._load (node:internal/modules/cjs/loader:787:27)
[egg-scripts] at Function.runMain (pkg/prelude/bootstrap.js:1979:12)
[egg-scripts] at node:internal/main/run_main_module:17:47 {
[egg-scripts] code: 'MODULE_NOT_FOUND',
[egg-scripts] requireStack: []
[egg-scripts] }
[egg-scripts]
[egg-scripts] Node.js v18.5.0
[egg-scripts]
[egg-scripts] Start got error, see /root/logs/master-stderr.log

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@atian25@mansonchor@licaide