feat: support pkgInfo.eggScriptsConfig.require by hyj1991 · Pull Request #47 · eggjs/scripts

hyj1991 · 2021-09-14T03:11:27Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

support:

{
"name": "example",
"eggScriptConfig": {
"require": [
"./inject.js"
]
}
}

The current pkgInfo.eggScriptConfig.require need to provide full path, this pr aims to support relative path & npm pkg.

hyj1991 · 2021-09-14T03:13:32Z

Waiting for #48 revert.

codecov · 2021-09-14T03:53:32Z

Codecov Report

Merging #47 (3b49af1) into master (499dedd) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #47 +/- ##
==========================================
+ Coverage 99.15% 99.60% +0.44% 
==========================================
Files 6 6 Lines 237 252 +15 Branches 46 50 +4 ==========================================
+ Hits 235 251 +16 + Misses 2 1 -1

Impacted Files	Coverage Δ
lib/command.js	`100.00% <100.00%> (ø)`
lib/helper.js	`100.00% <0.00%> (+4.54%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499dedd...3b49af1. Read the comment docs.

atian25 · 2021-09-14T07:06:01Z

 }
+
+ // read `egg.require` from package.json
+ if (argv.require && Array.isArray(argv.require)) {


这段是不是该放在 for 前面，不然 pkgInfo 的 require 和 --require 会覆盖？我们应该是需要合并。

atian25 · 2021-09-14T07:43:49Z

 }
 }
+
+ delete argv.require;


argv.require 有哪里插入到 execArgvObj.require 了么？（不确定 common-bin 里面的逻辑是否执行了）
下面那个单测，多加个 --require 验证下是否合并了。

https://github.com/eggjs/egg-scripts/pull/47/files/9f3bcf624beb545d40e1b1e6c39251f93e964f7c#diff-d8db36db6bfb32591336006f1dc1adee9e2caf7b021469995aa687c5c5723d0cR61-R64
这边，这样顺便也解决了 --require 只能传递全路径的易用性（并且兼容以前的全路径传递），两边合并下作为 execObject 传递逻辑上清晰一些

https://github.com/eggjs/egg-scripts/pull/47/files#diff-cd3896294facbcd40ebed616bbfdb8076c3f4cecb233872dde55add3cab4d57fR48
补了一个 --require=./inject2 的单测

feat: support pkgInfo.eggScriptsConfig.require
aeba4cf