[Maintenance] Change to Poetry for Package Management - #34
Merged
Conversation
| google-api-python-client = "^2.88.0" | ||
| PyYAML = "^6.0" | ||
| requests = "^2.30.0" | ||
| pandas = { version = "2.0.2", optional = true } |
Contributor
There was a problem hiding this comment.
why here and extras?
Contributor
Author
There was a problem hiding this comment.
Based on my understanding, both are needed. The tool.poetry.extras allows us to use -E argument with poetry install but it needs to point to a variable pandas which is then referenced with the version under tool.poetry.dependencies.
Reference: https://towardsdatascience.com/python-poetry-83f184ac9ed1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adjusts the package management of SWAT to Poetry from
setup.py.To install package:
poetry install(base installation)poetry install --extras "audit_support"(base installation w/ Pandas for GWS auditing)@brokensound77