Skip to content

[couchbase] Add Integration Package with Node Data Stream - #3771

Merged
kush-elastic merged 8 commits into
elastic:mainfrom
bhagyaraj-crest:package_couchbase_node
Oct 18, 2022
Merged

[couchbase] Add Integration Package with Node Data Stream#3771
kush-elastic merged 8 commits into
elastic:mainfrom
bhagyaraj-crest:package_couchbase_node

Conversation

@bhagyaraj-crest

@bhagyaraj-crestbhagyaraj-crest commented Jul 20, 2022•
edited by kush-elastic
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Generated the skeleton of Couchbase integration package.
  • Added 1 data stream ( node )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.
  • Update Manifest related changes to bring host variables in the package level and also update relative changes in the .hbs files and test files

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/couchbase directory.
  • Run the following command to run tests.

elastic-package test

ss1
ss2

Related issues

@elasticmachine

elasticmachine commented Jul 20, 2022•
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T12:48:37.384+0000

  • Duration: 30 min 18 sec

Test stats 🧪

TestResults
Failed0
Passed41
Skipped0
Total41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajaniyug-rajani added enhancement New feature or request Integration:couchbase Couchbase Team:Service-Integrations Label for the Observability Service Integrations team labels Jul 20, 2022
@yug-rajaniyug-rajani linked an issue Jul 20, 2022 that may be closed by this pull request
Create Couchbase package #613
Closed
8 tasks
@yug-rajani

yug-rajani commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Jul 20, 2022•
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (10/10)💚
Files100.0% (10/10)💚 2.525
Classes100.0% (10/10)💚 2.525
Methods100.0% (72/72)💚 9.359
Lines100.0% (1076/1076)💚 8.626
Conditionals100.0% (0/0)💚

@yug-rajani

yug-rajani commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

/test

yug-rajani
yug-rajani approved these changes Jul 22, 2022
View reviewed changes

@yug-rajaniyug-rajani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please change as per the nits suggested in #3666

@kush-elastickush-elastic mentioned this pull request Aug 3, 2022
Merged
4 tasks
This was referenced Aug 8, 2022
Merged
Merged
@yug-rajani
yug-rajani marked this pull request as ready for review August 12, 2022 08:55
@yug-rajani
yug-rajani requested a review from a team as a code ownerAugust 12, 2022 08:55
This was referenced Aug 16, 2022
Merged
Closed
@ritalwar
ritalwar self-requested a review August 23, 2022 05:11
@kush-elastickush-elastic mentioned this pull request Aug 23, 2022
Merged
4 tasks
This was referenced Aug 26, 2022
Merged
Merged
@yug-rajani
yug-rajani marked this pull request as draft September 1, 2022 06:14
@kush-elastickush-elastic mentioned this pull request Sep 8, 2022
Merged
4 tasks
@kush-elastic

kush-elastic commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Oct 11, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

Package couchbase 👍(7) 💚(2) 💔(1)

Expand to view
Data streamPrevious EPSNew EPSDiff (%)Result
cluster19607.8416129.03-3478.81 (-17.74%)💔

To see the full report comment with /test benchmark fullreport

@kush-elastic
kush-elastic marked this pull request as ready for review October 12, 2022 04:58
@kush-elastic
kush-elastic merged commit 31cfbdb into elastic:mainOct 18, 2022
@kush-elastickush-elastic mentioned this pull request Nov 1, 2022
Merged
4 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@bhagyaraj-crest@yug-rajani@kush-elastic
[couchbase] Add Integration Package with Node Data Stream (elastic#3771)
5bc98de
* Add Couchbase integration with Node data stream
* Update changelog entry
* Update details in README and Couchbase logo
* Nits
* Update depricated visualization
Co-authored-by: Yug Rajani <96041884+yug-elastic@users.noreply.github.com>
Co-authored-by: kush-elastic <kush.rana@elastic.co>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalit-satapathylalit-satapathyAwaiting requested review from lalit-satapathy
2 more reviewers
@yug-rajaniyug-rajaniyug-rajani approved these changes
@ritalwarritalwarritalwar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kush-elastickush-elastic

Labels

enhancementNew feature or requestIntegration:couchbaseCouchbaseTeam:Service-IntegrationsLabel for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Couchbase package

5 participants

@bhagyaraj-crest@elasticmachine@yug-rajani@kush-elastic@ritalwar