Skip to content

[GCP] Fix kubernetes.io service prefix indendation - #4355

Merged
2 commits merged into
mainfrom
unknown repository
Sep 30, 2022
Merged

[GCP] Fix kubernetes.io service prefix indendation#4355
2 commits merged into
mainfrom
unknown repository

Conversation

@ghost

Copy link
Copy Markdown

What does this PR do?

Fixes kubernetes.io service prefix indentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@endorama

endorama commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

This error is affecting other data streams as well (tested with compute and dataproc). I've no idea why this would "leak" to other data streams.

Trying to add an integration from Kibana UI resulted in this error:

bad indentation of a mapping entry at line 8, column 28: service_metric_prefix: kubernetes.io/ ^

@elasticmachine

elasticmachine commented Sep 30, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

Package gcp 👍(0) 💚(0) 💔(5)

Expand to view
Data streamPrevious EPSNew EPSDiff (%)Result
audit1915.711474.93-440.78 (-23.01%)💔
dns2739.731782.53-957.2 (-34.94%)💔
firewall3174.61972.39-1202.21 (-37.87%)💔
loadbalancing_logs4878.053412.97-1465.08 (-30.03%)💔
vpcflow4166.672192.98-1973.69 (-47.37%)💔

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Sep 30, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-09-30T09:26:00.186+0000

  • Duration: 20 min 32 sec

Test stats 🧪

TestResults
Failed0
Passed82
Skipped0
Total82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (5/5)💚
Files100.0% (5/5)💚 2.792
Classes100.0% (5/5)💚 2.792
Methods90.816% (89/98)👍 1.222
Lines95.752% (1375/1436)👍 4.217
Conditionals100.0% (0/0)💚

@ghost
ghost marked this pull request as ready for review September 30, 2022 09:46
@ghost
ghost requested review from a team as code ownersSeptember 30, 2022 09:46
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@endorama@elasticmachine@mrg-elastic