Skip to content

chore: migrate to TypeScript - #266

Merged
erickzhao merged 7 commits into
nextfrom
feat/migrate-to-typescript
Jun 26, 2025
Merged

chore: migrate to TypeScript#266
erickzhao merged 7 commits into
nextfrom
feat/migrate-to-typescript

Conversation

@hitarth-gg

@hitarth-gghitarth-gg commented Jun 19, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR migrates the initial prototype (#265) to TypeScript.

  • The core logic remains unchanged.
  • Replaced Babel loader with ts-loader in the Webpack configuration.
  • Updated the folder structure slightly.
  • Planning to address the usage of Session, Service Worker, and its preload script in a future PR.

samuelmaddock
samuelmaddock approved these changes Jun 19, 2025
View reviewed changes

@samuelmaddocksamuelmaddock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, but overall looks great!

Comment threadsrc/extension/tsconfig.json Outdated
Comment threadwebpack.node.config.ts Outdated
dsanders11
dsanders11 previously requested changes Jun 19, 2025
View reviewed changes
Comment threadLICENSE
Comment threadpackage.json Outdated
Comment threadpackage.json Outdated
@hitarth-gg
hitarth-ggforce-pushed the feat/migrate-to-typescript branch from 09571c4 to 009d412CompareJune 20, 2025 13:29
yangannyx
yangannyx reviewed Jun 23, 2025
View reviewed changes
Comment threadsrc/extension/tsconfig.json
@@ -0,0 +1,17 @@
{
"compilerOptions": {

@yangannyxyangannyxJun 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add "extends": "@tsconfig/node22/tsconfig.json", to stay consistent with tsconfig standards being set by the Node 22 migration

@yangannyxyangannyxJun 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not sure if we should remove "target": "es2020", and inherit the target value from the node22 tsconfig.json defaults (es2022) cc @dsanders11

@hitarth-gghitarth-ggJun 26, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up removing "target": "es2020", for now, so that it can be inherited from @tsconfig/node22 - 3559fb0

yangannyx
yangannyx reviewed Jun 23, 2025
View reviewed changes
Comment threadpackage.json Outdated
"autoprefixer": "^10.4.21",
"babel-loader": "^10.0.0",
"@types/chrome": "^0.0.326",
"@types/node": "^24.0.1",

@yangannyxyangannyxJun 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we're standardizing on ~22.10.7

@hitarth-gghitarth-ggJun 26, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - 4361022

@erickzhao
erickzhao dismissed dsanders11’s stale reviewJune 25, 2025 19:44

All changes were addressed

@erickzhao
erickzhao merged commit 8c11518 into nextJun 26, 2025
@dsanders11
dsanders11 deleted the feat/migrate-to-typescript branch July 19, 2025 01:21
@hitarth-gghitarth-gg mentioned this pull request Jul 19, 2025
Open
23 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangannyxyangannyxyangannyx approved these changes
@erickzhaoerickzhaoerickzhao approved these changes
@dsanders11dsanders11Awaiting requested review from dsanders11
+1 more reviewer
@samuelmaddocksamuelmaddocksamuelmaddock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GSoC 2025

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hitarth-gg@samuelmaddock@dsanders11@yangannyx@erickzhao