Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

VersionStringOptions.InternalFilename should be InternalName #171

Description

@russellmcc

The VersionStringOptions interface defines InternalFilename as a property name:

/** Internal name of the file. Usually, this string should be the original filename, without the extension. */
InternalFilename?: string

However, Windows docs for StringFileInfo documents InternalName, not InternalFilename

Since the Node wrapper passes object keys verbatim to --set-version-string, using InternalFilename writes a non-standard field into the binary's version info rather than the intended InternalName field.

The property should be renamed to InternalName in index.d.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions