Uh oh!
There was an error while loading. Please reload this page.
src: replace SetAccessor w/ SetAccessorProperty - #38
Conversation
PR-URL: nodejs/node#17665Fixes: nodejs/node#17636 Refs: nodejs/node#16482 Refs: nodejs/node#16860 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasonrudolph
commented
Jun 14, 2018
Thank you, @ckerr! ⚡🙇 |
alexeykuzmin
commented
Jun 14, 2018
@ckerr Is it a clean cherry-pick or you made some changes? |
Remove reliance on V8-specific error messages in test/parallel/test-tls-external-accessor.js. Check that the error is a `TypeError`. The test should now be successful without modification using ChakraCore. Backport-PR-URL: nodejs/node#20456 PR-URL: nodejs/node#16272 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ckerr
commented
Jun 15, 2018
@alexeykuzmin: @jasonrudolph found the upstream patch that fixes the tests too, nodejs/node@7eba62e I've confirmed that Node's tests pass when I check out v8.9.3 and then cherry-pick nodejs/node@efffcc2 and nodejs/node@7eba62e together |
jasonrudolph
commented
Jun 15, 2018
Including the failing test output here for reference: That failure appears to be resolved by nodejs/node#16272, which was backported to 8.x in nodejs/node#20478 via nodejs/node@7eba62e. I've cherry-picked that commit onto this branch, and that fixes the failing test. |
Cherry-picks nodejs/node@efffcc2 into our
electron-node-v8.9.3branch for use in a future Electron 2.0.x release.Requested by @jasonrudolph as a possible fix for electron/electron#13061 when running tests in headless mode in Atom (atom/atom#17409).