Skip to content

♻️ Refactor Actions to accept email for GitLab - #46

Merged
amadeu01 merged 9 commits into
add-support-email-from-pairsfrom
ac-wt/accept-user-email-in-add-command
Oct 30, 2020
Merged

♻️ Refactor Actions to accept email for GitLab#46
amadeu01 merged 9 commits into
add-support-email-from-pairsfrom
ac-wt/accept-user-email-in-add-command

Conversation

@amadeu01

@amadeu01amadeu01 commented Sep 23, 2020

Copy link
Copy Markdown
Member

Closes: #27

Note:

  • we do not handle the case where the user attempts to add its username/email multiple times;
  • we are not validating email formats.

@amadeu01amadeu01 added the enhancement New feature or request label Sep 23, 2020
Comment threadlib/storage.ex
@@ -0,0 +1,20 @@
defmodule GitPair.Storage do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules should have a @moduledoc tag.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will do it later.

@amadeu01amadeu01 added this to the v1.0.0 milestone Sep 23, 2020
@amadeu01
amadeu01force-pushed the ac-wt/accept-user-email-in-add-command branch from bc80fce to f84a7dcCompareSeptember 23, 2020 01:36
@wevtimoteowevtimoteo modified the milestones: v1.0.0, v1.1.0Sep 29, 2020
Amadeu 🦄 Lindo 🌈 added 2 commits October 6, 2020 21:13
This module will be responsible to coordinate all interactions with `git config` command.
@amadeu01
amadeu01force-pushed the ac-wt/accept-user-email-in-add-command branch from f84a7dc to 3675765CompareOctober 7, 2020 00:18
Amadeu 🦄 Lindo 🌈and others added 5 commits October 6, 2020 22:07
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
For now, we are only using the `Storage` module for adding users. However, we are planning to refactor `Actions` to remove all `System` calls.
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
Comment threadtest/actions_test.exs
Comment threadlib/git_pair/behaviours/storage_behaviour.ex Outdated
Amadeu 🦄 Lindo 🌈and others added 2 commits October 6, 2020 22:18
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
Co-authored-by: wevtimoteo <wevtimoteo@users.noreply.github.com>
@sourcelevel-bot

Copy link
Copy Markdown

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

See more details about this review.

@amadeu01
amadeu01 marked this pull request as ready for review October 7, 2020 01:26
@wevtimoteo
wevtimoteo changed the base branch from main to add-support-email-from-pairsOctober 29, 2020 23:48
@amadeu01
amadeu01 merged commit 2c2f609 into add-support-email-from-pairsOct 30, 2020
@amadeu01
amadeu01 deleted the ac-wt/accept-user-email-in-add-command branch October 30, 2020 00:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine co-author anonymous email by remote origin address

2 participants

@amadeu01@wevtimoteo