Uh oh!
There was an error while loading. Please reload this page.
tap global console, to toggle spinner on/off. This ensures we avoid p… - #76
Open
stefanpenner wants to merge 1 commit into
Open
tap global console, to toggle spinner on/off. This ensures we avoid p…#76stefanpenner wants to merge 1 commit into
stefanpenner wants to merge 1 commit into
Conversation
…roducing garbage output (when possible).
rwjblue
reviewed
May 2, 2019
rwjblue
left a comment
Member
There was a problem hiding this comment.
Seems like this will wrap many times (once for each UI instance created), I believe we need to avoid that. In addition, we need a way to clean up in general I think...
stefanpenner
commented
May 2, 2019
ContributorAuthor
Ya, I thought about that, but actually that may be a feature not a bug. Remember how we did capture exit? |
stefanpenner
commented
May 2, 2019
ContributorAuthor
that being said wrapping once per console-ui node_module would be a fair balance, it wont grow unbounded. |
stefanpenner
commented
May 2, 2019
ContributorAuthor
Ah, it's actually not possible unless we add the concept of "destroy" and then have all consumers use "destroy" appropriately. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we avoid producing garbage output (when possible).