Skip to content

smart merge package.json - #108

Merged
kellyselden merged 1 commit into
masterfrom
package-json
Sep 17, 2017
Merged

smart merge package.json#108
kellyselden merged 1 commit into
masterfrom
package-json

Conversation

@kellyselden

@kellyseldenkellyselden commented Sep 4, 2017

Copy link
Copy Markdown
Member

@kellyselden
kellyseldenforce-pushed the package-json branch 10 times, most recently from ddc7e26 to 2cb55d7CompareSeptember 5, 2017 06:18
@kellyselden

Copy link
Copy Markdown
MemberAuthor

I don't think merge is correct, this just happened:

screen shot 2017-09-06 at 11 41 06 am

@kellyselden

Copy link
Copy Markdown
MemberAuthor

package.json needs to be staged after merge.

@kellyselden

kellyselden commented Sep 7, 2017

Copy link
Copy Markdown
MemberAuthor

If symlinks are broken in node_modules (npm link ember-cli, then delete globally), you get this error

 ember-cli-update Error: ENOENT: no such file or directory, stat './node_modules/.bin/ember'
ember-cli-update at Object.fs.statSync (fs.js:968:11)
ember-cli-update at Object.statSync (/Users/kelly.selden/code/ember-cli-update/node_modules/graceful-fs/polyfills.js:297:22)
ember-cli-update at readSync (/Users/kelly.selden/code/ember-cli-update/node_modules/fixturify/index.js:10:20)
ember-cli-update at readSync (/Users/kelly.selden/code/ember-cli-update/node_modules/fixturify/index.js:14:20)
ember-cli-update at Object.readSync (/Users/kelly.selden/code/ember-cli-update/node_modules/fixturify/index.js:14:20)
ember-cli-update at convertToObj (/Users/kelly.selden/code/ember-cli-update/node_modules/git-diff-apply/src/index.js:98:23)
ember-cli-update at ncp.then (/Users/kelly.selden/code/ember-cli-update/node_modules/git-diff-apply/src/index.js:56:16) +0ms

fixturify is trying to crawl it and failing. All the more reason to get joliss/node-fixturify#8 done. This is probably only an issue in global mode, because it won't run as an addon if ember-cli can't be resolved.

@kellyselden
kellyseldenforce-pushed the package-json branch 3 times, most recently from a3f675a to 7c1e23cCompareSeptember 13, 2017 15:59
@kellyselden

Copy link
Copy Markdown
MemberAuthor

This has been working so well for me that I don't think an opt-in option would be worth it, so it will just be default.

@kellyselden
kellyselden merged commit 6ba4c84 into masterSep 17, 2017
@kellyselden
kellyselden deleted the package-json branch September 17, 2017 03:59
@kellyselden

Copy link
Copy Markdown
MemberAuthor

Woohoo!

@kellyselden

Copy link
Copy Markdown
MemberAuthor

Released in v0.7.0

@rwjblue

Copy link
Copy Markdown
Member

👏🙌😻

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More intelligent handling of package.json.

2 participants

@kellyselden@rwjblue