Aliased class name bindings in templates - #242
Merged
Merged
Conversation
There was a problem hiding this comment.
Why not
var split = property.split(':'),
className = split[1],
property = split[0];?
Member
|
Seems good, other than the formatting suggestion by James. I assume all tests pass on all major browsers? |
Member
Author
|
The tests are passing in Chrome. All I've done is copy over code from sproutcore-views into sproutcore-handlebars. There is duplicate code that should probably get unified. |
Member
Author
|
Here are the two similar functions that handle parsing classNameBindings: https://github.com/amberjs/amber.js/blob/master/packages/sproutcore-views/lib/views/view.js#L476 |
ebryn
added a commit
that referenced
this pull request
Dec 12, 2011
…emplates Aliased class name bindings in templates
sandstrom
pushed a commit
to sandstrom/ember.js
that referenced
this pull request
Jun 17, 2021
…rn/ember-cli-htmlbars-inline-precompile-2.1.0 Bump ember-cli-htmlbars-inline-precompile from 2.0.0 to 2.1.0
mansona
pushed a commit
to mansona/ember.js
that referenced
this pull request
Mar 10, 2026
Prevent context matching if the oldContext is null
lifeart
added a commit
to lifeart/ember.js
that referenced
this pull request
Jul 2, 2026
0.0.71 ships the four bridge-deletion host seams: emberjs#239 (emission flags surfaced on compileTemplate's return), emberjs#240 (normalizeAttrValue attr-coercion hook, WITH_EMBER_INTEGRATION-gated), emberjs#241 ($_dc carries splat $fw natively), emberjs#242 (onComponentContextCreated — the component twin of onRowContextCreated). Full --baseline gate with the follow-up consumption commit: baseline ok — no green->red, 10233/10234 across 922 modules (lone non-pass = the known custom-plugins DEBUG non-bug). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.