Custom Model Classes by igorT · Pull Request #487 · emberjs/rfcs

igorT · 2019-05-09T18:30:34Z

runspired · 2019-05-09T20:05:23Z

+ kind: 'hasMany'| 'belongsTo';
+ type: string;
+ options: { [key: string]: any } ;
+ name: string;


we should validate that this is in fact what we currently expose / want to document as info concerning inversePropertyNameinverseType and isPolymorphic is typically available as well.

Thats a very good point. isPolymorphic should be available from the options. We currently in practice expose a bunch of underscored properties for inverses, but all of that data is calculable given the exposed public data. I would prefer to keep it private, and figure out in the schema work if we need to expose it

dgeb · 2019-06-19T18:01:03Z

I discussed this with @igorT today.

One concern I've had here is that type is used inconsistently between RelationshipDefinition and AttributeDefinition, but Igor said that this is a legacy inconsistency and that changing this now would lead to breakages.

Also, some method return values on RecordDataWrapper are untyped (e.g. getErrors, getMeta).

I'm fine moving this to FCP if others are. I will give it another pass over the weekend.

igorT · 2019-06-19T20:22:48Z

I have implemented a slightly older version of this api(pending some cleanup) at ember-m3/ember-m3#294. It passes all the tests without any usage of _internalModel or other private apis

rwjblue · 2019-06-19T20:33:50Z

+}
+```
+
+Instead of exposing the entire RecordData Class, we expose only the local facing methods and hide the server/adapter facing methods that the Model should not have access to, by giving a RecordData lookup method to `instantiateRecord`


Instead of exposing the entire RecordData Class
On what? Needs a slight prose tweak here

dgeb · 2019-06-23T21:44:25Z

+We need to make the following changes:
+
+* expose a method on the store for instantiating a record
+* add a hook to be notified when a record is being destroyed for potential cleanup


Clarify interaction with unloadRecord

dgeb · 2019-06-23T22:07:47Z

I've left a couple suggestions but don't consider anything blocking.

In addition to the comments I left, I'd like to eventually iron out inconsistencies between usage of type in the relationship and attribute definitions, but I understand those interfaces are not being introduced by this RFC.

Implements RFC emberjs/rfcs#487

This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

* master: (56 commits) Fix code examples & add ember-cli release version in emberjs#637 Update FCP guidance to include Discord Update RFC 085421 ready-for-release PR URL Advance RFC {{ inputs.rfc-number }} to Stage ready-for-release feat: EmberData Cache v2.1 finalize lifetimes Update text/0860-ember-data-request-service.md Update RFC 496, typos, correct field name add note chore: update RequestService url with finalized design details Move emberjs#331 deprecate-globals-resolver to recommended Correct metadata for emberjs#487 custom model classes Move emberjs#625 helper-managers to recommended Add release date and version for 776 Update RFC 0776 released PR URL Advance RFC {{ inputs.rfc-number }} to Stage released Update RFC 0739 ready-for-release PR URL Advance RFC {{ inputs.rfc-number }} to Stage ready-for-release Deprecate `ember-mocha` Add title of RFC to advancement PR titles ...

runspired added the T-ember-data RFCs that impact the ember-data library label May 9, 2019

This comment has been minimized.
Sign in to view

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

runspired reviewed May 9, 2019
View reviewed changes

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

HeroicEric reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

hjdivad reviewed May 9, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

igorT changed the title ~~[Data] Custom Model Classes~~Custom Model ClassesMay 15, 2019

igorT force-pushed the igor/custom-model-classes branch 2 times, most recently from 959be70 to 10ade6fCompare May 22, 2019 19:59

runspired reviewed May 22, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated
Comment threadtext/0000-custom-model-classes.md

hjdivad reviewed May 22, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md
Comment threadtext/0000-custom-model-classes.md Outdated
Comment threadtext/0000-custom-model-classes.md

hjdivad reviewed May 22, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md

This comment has been minimized.
Sign in to view

igorT commented May 22, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

rwjblue reviewed May 22, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

This comment has been minimized.
Sign in to view

runspired mentioned this pull request Jun 5, 2019
Model Lifecycle Hooks #123
Closed

runspired mentioned this pull request Jun 18, 2019
[QUEST] 🌲Project Trim 🌲 warp-drive-data/warp-drive#6166
Closed
65 tasks

igorT force-pushed the igor/custom-model-classes branch from 47a6f8c to c6c4e85Compare June 19, 2019 20:17

rwjblue reviewed Jun 19, 2019
View reviewed changes

emberjs deleted a comment from rwjblue Jun 19, 2019

dgeb reviewed Jun 23, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

dgeb reviewed Jun 23, 2019
View reviewed changes

Comment threadtext/0000-custom-model-classes.md Outdated

igorT added the Final Comment Period label Jun 24, 2019

igorT force-pushed the igor/custom-model-classes branch 2 times, most recently from 3575893 to 3a8b8b6Compare June 29, 2019 03:39

Custom Model Classes
d8d46dd

igorT force-pushed the igor/custom-model-classes branch from 3a8b8b6 to d8d46ddCompare June 29, 2019 03:41

igorT merged commit a418eaa into emberjs:masterJun 29, 2019

igorT mentioned this pull request Aug 6, 2019
Custom Model Classes warp-drive-data/warp-drive#6313
Merged

igorT added a commit to warp-drive-data/warp-drive that referenced this pull request Aug 20, 2019
Custom Model Class impl (#6313)
f472f27
Implements RFC emberjs/rfcs#487

runspired mentioned this pull request Sep 1, 2023
[DATA] Improved Debugging Experience warp-drive-data/warp-drive#8818
Closed

igorT pushed a commit to ember-m3/ember-m3 that referenced this pull request Sep 28, 2019
Implement support for Ember Data custom model classes
ffd774e
This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

igorT pushed a commit to ember-m3/ember-m3 that referenced this pull request Sep 28, 2019
Implement support for Ember Data custom model classes
cfbd458
This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

igorT pushed a commit to ember-m3/ember-m3 that referenced this pull request Sep 28, 2019
Implement support for Ember Data custom model classes
a7f0158
This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

igorT pushed a commit to ember-m3/ember-m3 that referenced this pull request Sep 28, 2019
Implement support for Ember Data custom model classes
f08ba84
This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

igorT pushed a commit to ember-m3/ember-m3 that referenced this pull request Sep 28, 2019
Implement support for Ember Data custom model classes
e6604c4
This allows us to move away from using _internalModel and private apis, by using apis descibred at emberjs/rfcs#487

wagenet added a commit that referenced this pull request Mar 13, 2023
Correct metadata for#487custom model classes
c782907

Uh oh!

Uh oh!

Conversation

igorT commented May 9, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

runspiredMay 9, 2019

Choose a reason for hiding this comment

Uh oh!

igorTMay 22, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

dgeb commented Jun 19, 2019

Uh oh!

igorT commented Jun 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rwjblueJun 19, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dgebJun 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dgeb commented Jun 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

igorT commented May 9, 2019•
edited
Loading