Skip to content

Deprecation Staging - #649

Merged
rwjblue merged 6 commits into
emberjs:masterfrom
mehulkar:mk/deprecation-staging
Aug 14, 2020
Merged

Deprecation Staging#649
rwjblue merged 6 commits into
emberjs:masterfrom
mehulkar:mk/deprecation-staging

Conversation

@mehulkar

@mehulkarmehulkar commented Jul 24, 2020•
edited
Loading

Copy link
Copy Markdown

Thanks for @pzuraq,@rwjblue, @wycats, and the rest of the strike team for fleshing out these ideas and letting me play scribe!

rendered

@amyrlamamyrlam mentioned this pull request Jul 24, 2020
Merged
28 tasks
@rwjblue

rwjblue commented Jul 24, 2020

Copy link
Copy Markdown
Member

Thanks for working on this @mehulkar!

@rwjbluerwjblue added the T-framework RFCs that impact the ember.js library label Jul 24, 2020
@rwjblue

rwjblue commented Jul 24, 2020

Copy link
Copy Markdown
Member

Just FYI we discussed this at today's core team meeting. Nothing really to report (I don't think most folks have had a chance to review yet), but folks were excited about the progress. 😸

@camerondubas

camerondubas commented Jul 30, 2020

Copy link
Copy Markdown

Nice! I don't have much to add here, although I think this is a nice progression of the deprecation system.

Could the rendered link be added to the PR description? Thanks!

@rwjblue

rwjblue commented Jul 31, 2020

Copy link
Copy Markdown
Member

@camerondubas - Yep, thanks for pointing that out!

rwjblue
rwjblue reviewed Jul 31, 2020
View reviewed changes
Comment threadtext/0000-deprecation-staging.md Outdated
mehulkar
mehulkar commented Jul 31, 2020
View reviewed changes
Comment threadtext/0649-deprecation-staging.md Outdated
@rwjblue

rwjblue commented Jul 31, 2020

Copy link
Copy Markdown
Member

We chatted about this today in the core team meeting. The team is very happy with the overall design and we are eager to move forward. The one area that was still a bit of a concern was around the stage names. We are pretty happy with available but there was some back and forth about the required name. After we went back and forth a bit, we'd like to change required to enabled. Other than that one change, I think we are collectively very 👍 and would like to move forward!

@mehulkar

mehulkar commented Jul 31, 2020

Copy link
Copy Markdown
Author

🥳 great to hear! Enabled seems good to me too, I've updated the text.

@rwjblue

rwjblue commented Aug 7, 2020

Copy link
Copy Markdown
Member

Thanks for updating that @mehulkar! We discussed this in the most recent core team meeting, and have decided to move this into final comment period.

@mehulkarmehulkar mentioned this pull request Aug 10, 2020
Closed
@rwjblue

rwjblue commented Aug 14, 2020

Copy link
Copy Markdown
Member

Chatted about this in the core team meeting today, we are still super happy with the direction forward and are ready to land this one!

@rwjblue
rwjblue merged commit 3f61cac into emberjs:masterAug 14, 2020
@mehulkar
mehulkar deleted the mk/deprecation-staging branch August 26, 2020 18:36
@mehulkarmehulkar mentioned this pull request Sep 8, 2020
Merged
mehulkar pushed a commit to mehulkar/ember.js that referenced this pull request Oct 7, 2020
Mehul Kar
Add for and since options to depreacte() function
1f420ce
This implements the first stage of the Deprecation Staging RFC
emberjs/rfcs#649
This commit also:
- deprecates the usage of deprecate() function without passing
these options
- Updates all the usages of deprecate() in the repo to pass
these options.
@pzuraqpzuraq mentioned this pull request Feb 3, 2021
Closed
@SergeAstapovSergeAstapov mentioned this pull request May 28, 2021
Merged
@igorTigorT mentioned this pull request Aug 2, 2021
Merged
@emberjs-rfcs-botemberjs-rfcs-bot mentioned this pull request Jan 12, 2023
Draft
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjbluerwjbluerwjblue left review comments

Assignees

@rwjbluerwjblue

@pzuraqpzuraq

Labels

Final Comment PeriodT-frameworkRFCs that impact the ember.js library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehulkar@rwjblue@camerondubas@pzuraq