Ignore messages from terminated workers - #18761
Merged
Merged
Conversation
sbc100
force-pushed
the
pthread_terminate
branch
4 times, most recently
from
February 15, 2023 21:45
f3e2a48 to
66ae342
Compare
tlively
approved these changes
Feb 16, 2023
This could help with some of the flaky thread tests we have been seeing as it means that we never try to process messages from already-terminated threads. Split out from #18754
sbc100
force-pushed
the
pthread_terminate
branch
from
February 16, 2023 17:51
66ae342 to
644f752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could help with some of the flaky thread tests we have been seeing as it means that we never try to process messages from already-terminated threads.
Split out from #18754