Remove more dead python code found using deadcode module. NFC - #25359
Merged
Merged
Conversation
The remaining dead code being reported is false positives I believe.
kripken
reviewed
Sep 22, 2025
kripken
reviewed
Sep 22, 2025
kripken
approved these changes
Sep 22, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 2, 2025
This was broken by emscripten-core#25359. I though I was just moving this assignment to the correct place, but it seems like it broken emrun because the 1.1 protocol was not actually enabled before. Once enabled it seems like this was causing `httpd.server_close` to hang forever. Fixes: emscripten-core#25654
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
…ripten-core#25359) The remaining dead code being reported is false positives I believe.
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
This was broken by emscripten-core#25359. I though I was just moving this assignment to the correct place, but it seems like it broken emrun because the 1.1 protocol was not actually enabled before. Once enabled it seems like this was causing `httpd.server_close` to hang forever. Fixes: emscripten-core#25654
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining dead code being reported is false positives I believe.