Skip to content

PLAT-121645: Add support for new JSX Transform - #236

Merged
SkylerBaek merged 4 commits into
feature/react17from
feature/PLAT-121645
Feb 3, 2021
Merged

PLAT-121645: Add support for new JSX Transform#236
SkylerBaek merged 4 commits into
feature/react17from
feature/PLAT-121645

Conversation

@MikyungKim

@MikyungKimMikyungKim commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

This PR adds support for the new JSX transform.
We could turn the feature off by setting DISABLE_NEW_JSX_TRANSFORM to true via .env file for enact pack.
We can't turn the rule off for enact lint though.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

@hong6316hong6316 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong6316hong6316 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkylerBaek
SkylerBaek merged commit 4170360 into feature/react17Feb 3, 2021
@SkylerBaek
SkylerBaek deleted the feature/PLAT-121645 branch February 3, 2021 08:05
SkylerBaek pushed a commit that referenced this pull request Feb 26, 2021
* 9037 Fix dotenv file loading order
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Upgrade to React 17
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Update dependencies
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Revert react-refresh-webpack-plugin version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Replace inquirer with prompts
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Replace inquirer with prompts in eject
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* 9374 Fix: use default modules option from preset-env
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 (#231)
* PLAT-129601: Upgrade @pmmmwh/react-refresh-webpack-plugin module from 0.3.3 to 0.4.1
* Update CHANGELOG.md
* Update package-lock.json
* Update commands/eject.js (for fixing lint error)
* Update package.json 2
* 9964 Add TypeScript 4.x as peerDependency
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* PLAT-129600: Replace deprecated eslint-loader by eslint-webpack-plugin (#235)
* PLAT-129600: Replace eslint-loader to eslint-webpack-plugin
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* fix lint
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* PLAT-121645: Add support for new JSX Transform (#236)
* PLAT-121645: Add support for new JSX Transform
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* fix lint error
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* fix lint
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Added a guard
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update dependecies
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Update @enact/moonstone-template dependency
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* added changelog
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MikyungKim@hong6316@SkylerBaek