Skip to content

WRN-18582: Migrate to webpack5 - #264

Merged
hong6316 merged 10 commits into
feature/webpack5from
feature/WRN-18582
Mar 23, 2022
Merged

WRN-18582: Migrate to webpack5#264
hong6316 merged 10 commits into
feature/webpack5from
feature/WRN-18582

Conversation

@MikyungKim

@MikyungKimMikyungKim commented Mar 21, 2022•
edited by hong6316
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Migrated to webpack5

Resolution

Added private pack option --ilib-additional-path
Updated APIs for webpack5 changes
Replaced OptimizeCSSAssetsPlugin to CssMinimizerPlugin
#260 is included.

Additional Considerations

Links

WRN-18582

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

MikyungKimand others added 9 commits March 11, 2022 18:04
@MikyungKim
WRN-18582: webpack5 initial commit
49cf168
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
WRN-18582: Fixed serve issue
1a1a56c
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
WRN-18582: Added webpack cache config
09ef85a
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
applied more changes
08121e0
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
Added changelog
b23d209
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
fix
9c324d4
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
update listen to startCallback from webpack dev server
0feaa9a
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
fix filename..ext issue
a05cdf6
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@hong6316@MikyungKim
WRN-16762: Added support for tailwindcss and update dependencies (#263)
ea66262
* initial modules update(before wp5 update)
* npm audit fix
* Update package.json
* fix lint errors
* update CHANGELOG.md
* Update package.json
* revert CHANGELOG.mx
* revert jest 27
* revert npm-shrinkwrap.json
* revert pack/serve.js
* for removing conflict with #262, revert versions
* Update react-refresh-webpack-plugin version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update babel-jest version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update babel-plugin-dev-expression version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* remove unnecessary code
* revert file permission
* update dependencies
* update package.json
* Update package.json
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update package.json
* fix
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
hong6316
hong6316 reviewed Mar 22, 2022
View reviewed changes
Comment threadpackage.json Outdated
@MikyungKim
update changelog and package.json
e000317
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
hong6316
hong6316 approved these changes Mar 23, 2022
View reviewed changes

@hong6316hong6316 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong6316
hong6316 merged commit 11cc3e0 into feature/webpack5Mar 23, 2022
@hong6316
hong6316 deleted the feature/WRN-18582 branch March 23, 2022 00:21
hong6316 added a commit that referenced this pull request Apr 11, 2022
@MikyungKim@hong6316
WRO-231: Merge feature/webpack5 to develop (#268)
0116859
* WRN-18582: Migrate to webpack5 (#264)
* WRN-18582: webpack5 initial commit
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-18582: Fixed serve issue
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-18582: Added webpack cache config
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* applied more changes
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Added changelog
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* fix
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update `listen` to `startCallback` from webpack dev server
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* fix filename..ext issue
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-16762: Added support for tailwindcss and update dependencies (#263)
* initial modules update(before wp5 update)
* npm audit fix
* Update package.json
* fix lint errors
* update CHANGELOG.md
* Update package.json
* revert CHANGELOG.mx
* revert jest 27
* revert npm-shrinkwrap.json
* revert pack/serve.js
* for removing conflict with #262, revert versions
* Update react-refresh-webpack-plugin version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update babel-jest version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update babel-plugin-dev-expression version
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* remove unnecessary code
* revert file permission
* update dependencies
* update package.json
* Update package.json
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update package.json
* fix
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* update changelog and package.json
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
* WRN-12124: Remove deprecated babel-eslint module (#261)
* use @babel/eslint-parser
* remove babel-preset-react-app
* remove @babel/eslint-parser
* Revert "remove @babel/eslint-parser"
This reverts commit 1b8b37e.
* Revert "remove babel-preset-react-app"
This reverts commit b8579cb.
* Revert "use @babel/eslint-parser"
This reverts commit b73146a.
* babel-eslint -> @babel/eslint-parser
* unpinning enact repos
* remove babel-eslint related word in README.md
* Update README.md
* modify changelog & readme
* Update package.json
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* Update README.md
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* update npm-shrinkwrap.json
* update @babel/core to the same version of dev-utils
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* Move some dependencies to dev dependencies
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* WRN-19252: Pass ProgressPlugin to VerboseLogPlugin (#265)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-12748: Update eslint 8 related modules (#262)
* update eslint 8
* eslint 8 changes strict package exports(#14706), call another method
* revert js changes
* Update package.json
* restore eslintrc.js - 'prettier' (included 'prettier/babel', 'prettier/react')
* Update package.json
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* WRN-19694: Update to React18 (#266)
* update react version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update testing library for react18
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update react version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update dependencies
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update dev-utils branch
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* revert dev-utils version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-20481: Fix screenshot test build fail (#267)
* Added node-polyfill-webpack-plugin
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* added some comments
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* link dev-utils
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* WRN-20481: Fix lint error and revert packages version
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update change log
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
* update dependencies
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
@hong6316hong6316 mentioned this pull request Feb 15, 2024
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hong6316hong6316hong6316 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikyungKim@hong6316