Skip to content

WRO-7036: Remove passing ProgressPlugin to VerboseLogPlugin - #291

Merged
MikyungKim merged 3 commits into
developfrom
feature/WRO-7036
Jul 5, 2022
Merged

WRO-7036: Remove passing ProgressPlugin to VerboseLogPlugin#291
MikyungKim merged 3 commits into
developfrom
feature/WRO-7036

Conversation

@hong6316

@hong6316hong6316 commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

We found that we could access to "ProgressPlugin" component through "compiler.webpack.ProgressPlugin", instead of passing "ProgressPlugin" from CLI as we did in #265.
In this PR, we revert #265 and use dev-utils' ProgressPlugin itself.

Resolution

  • Remove passing "ProgressPlugin" to dev-utils

Additional Considerations

Links

WRO-7036

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

@hong6316
hong6316 requested a review from MikyungKimJuly 4, 2022 08:24
@MikyungKimMikyungKim changed the title WRO-7036: Remove passing "ProgressPlugin" to dev-utilsWRO-7036: Remove passing ProgressPlugin to VerbosePluginJul 5, 2022
Comment threadpackage.json Outdated
@MikyungKimMikyungKim changed the title WRO-7036: Remove passing ProgressPlugin to VerbosePluginWRO-7036: Remove passing ProgressPlugin to VerboseLogPluginJul 5, 2022

@MikyungKimMikyungKim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@MikyungKim
MikyungKim merged commit 74bfafe into developJul 5, 2022
@MikyungKim
MikyungKim deleted the feature/WRO-7036 branch July 5, 2022 07:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hong6316@MikyungKim