Add a check for 'required' before deletion

[haiyangdeperci]

Description

This pull request attempts to resolve a KeyError that arises when no required fields are present. It checks if there is a 'required' key in the content of the request as described by #6918.

[xordoquy]

Could you elaborate about "a KeyError that arises when no required fields are present" ?
PATCH request bypasses the required fields so the current implementation looks legit to me.

[haiyangdeperci]

@xordoquy The problem is that the content dictionary might not necessarily contain the key named 'required'. Thus, if that's the case, in the current implementation one gets a KeyError in del content['required'] because there is no such key.

Alternatively, you may change that portion of the code in the following way:

try:
delcontent['required']
exceptKeyError:
pass

[guimunarolo]

ifmethod=='PATCH':
content.pop('required', None)

[carltongibson]

Hi @guimunarolo — Could you add a test case (abstracting from the issue description) showing how the issue arises? Thanks!

[guimunarolo]

Hi @guimunarolo — Could you add a test case (abstracting from the issue description) showing how the issue arises? Thanks!

Hey @carltongibson - I just open a PR fixing this #6944

[carlfarrington]

Hi @guimunarolo — Could you add a test case (abstracting from the issue description) showing how the issue arises? Thanks!

Hey @carlfarrington - I just open a PR fixing this #6944

Hi, sorry, I think you meant @carltongibson :)

[guimunarolo]

Hi @guimunarolo — Could you add a test case (abstracting from the issue description) showing how the issue arises? Thanks!

Hey @carlfarrington - I just open a PR fixing this #6944

Hi, sorry, I think you meant @carltongibson :)

mb 😅

[carltongibson]

Closing in favour of #6944. Thanks all.