sslv3 alert handshake failure

[DouglasBlackwood]

• Initially raised as discussion sslv3 alert handshake failure httpx#3214 (comment)

Hi!

I've encountered an error lately. It happened once.

Here is the stack trace:

SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:1000)
[...]
 File "httpx/_client.py", line 1574, in request
 return await self.send(request, auth=auth, follow_redirects=follow_redirects)
 File "ddtrace/contrib/httpx/patch.py", line 137, in _wrapped_async_send
 resp = await wrapped(*args, **kwargs)
 File "httpx/_client.py", line 1661, in send
 response = await self._send_handling_auth(
 File "httpx/_client.py", line 1689, in _send_handling_auth
 response = await self._send_handling_redirects(
 File "httpx/_client.py", line 1726, in _send_handling_redirects
 response = await self._send_single_request(request)
 File "httpx/_client.py", line 1763, in _send_single_request
 response = await transport.handle_async_request(request)
 File "httpx/_transports/default.py", line 373, in handle_async_request
 resp = await self._pool.handle_async_request(req)
 File "httpcore/_async/connection_pool.py", line 216, in handle_async_request
 raise exc from None
 File "httpcore/_async/connection_pool.py", line 196, in handle_async_request
 response = await connection.handle_async_request(
 File "httpcore/_async/connection.py", line 99, in handle_async_request
 raise exc
 File "httpcore/_async/connection.py", line 76, in handle_async_request
 stream = await self._connect(request)
 File "httpcore/_async/connection.py", line 154, in _connect
 stream = await stream.start_tls(**kwargs)
 File "httpcore/_backends/anyio.py", line 80, in start_tls
 raise exc
 File "httpcore/_backends/anyio.py", line 71, in start_tls
 ssl_stream = await anyio.streams.tls.TLSStream.wrap(
 File "anyio/streams/tls.py", line 132, in wrap
 await wrapper._call_sslobject_method(ssl_object.do_handshake)
 File "anyio/streams/tls.py", line 140, in _call_sslobject_method
 result = func(*args)
 File "ssl.py", line 917, in do_handshake
 self._sslobj.do_handshake()

It happened during a request to another one of our servers. We perform this kind of request pretty often without any issues. This error happened only once.

I have the feeling that this error should be mapped to another higher-level exception.

Here is my environment:

• Python runtime: 3.12.3(3.12.3 (main, May 14 2024, 07:34:56) [GCC 12.2.0])
• httpx 0.27.0
• httpcore 1.0.5
• anyio 4.4.0

@tomchristie suggested to include and map SSLError -> httpcore.ConnectError.

httpcore/httpcore/_backends/anyio.py

Lines 63 to 67 in c96fdf7

	exc_map = {
	TimeoutError: ConnectTimeout,
	anyio.BrokenResourceError: ConnectError,
	anyio.EndOfStream: ConnectError,
	}

[lovelydinosaur]

Wonderful thanks @DouglasBlackwood - would you like to create a PR to resolve this?

[DouglasBlackwood]

Wonderful thanks @DouglasBlackwood - would you like to create a PR to resolve this?

Why not! I'm on it!