Skip to content

Add an UnsupportedProtocol exception - #128

Merged
lovelydinosaur merged 5 commits into
masterfrom
unsupported-protocol
Aug 2, 2020
Merged

Add an UnsupportedProtocol exception#128
lovelydinosaur merged 5 commits into
masterfrom
unsupported-protocol

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented Aug 2, 2020

Copy link
Copy Markdown
Contributor

Closes#124

Once we tie this exception through to httpx, this will allow us to drop enforce_http_url in httpx, and instead defer the decision entirely to the transport layer.

Will later allow us to support mounting transports on schemes other than http, https.

@lovelydinosaurlovelydinosaur added the enhancement New feature or request label Aug 2, 2020
@lovelydinosaurlovelydinosaur changed the title Add an UnsupportedProtocol exceptionAdd an UnsupportedProtocol exceptionAug 2, 2020
@lovelydinosaurlovelydinosaur added this to the 0.10.0 milestone Aug 2, 2020
florimondmanca
florimondmanca reviewed Aug 2, 2020
View reviewed changes
Comment threadhttpcore/_async/connection_pool.py Outdated
Comment threadtests/async_tests/test_interfaces.py Outdated
Comment threadtests/async_tests/test_interfaces.py Outdated
lovelydinosaurand others added 4 commits August 2, 2020 12:26
@lovelydinosaur@florimondmanca
Update httpcore/_async/connection_pool.py
25b00ac
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@lovelydinosaur@florimondmanca
Update tests/async_tests/test_interfaces.py
97e0590
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@lovelydinosaur@florimondmanca
Update tests/async_tests/test_interfaces.py
ed44c25
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@lovelydinosaur
Unasync
d9c673d
@lovelydinosaur
lovelydinosaur merged commit 4b0ee6f into masterAug 2, 2020
@lovelydinosaur
lovelydinosaur deleted the unsupported-protocol branch August 2, 2020 11:33
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 3, 2020
Merged
@KludexKludex mentioned this pull request May 11, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@florimondmancaflorimondmancaflorimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Introduce UnsupportedProtocol exception.

2 participants

@lovelydinosaur@florimondmanca